Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227353002: Refactor handling of library prefixes. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor handling of library prefixes. Closes #13632 BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/6b36c8acc61e54271a47a7b38b2678fba4269eb4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Patch Set 3 : Update unittest expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -39 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 5 chunks +56 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/diagnose_ambiguous_test.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 1 2 4 chunks +4 lines, -6 lines 0 comments Download
M tests/language/language_dart2js.status View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 5 months ago (2015-07-09 13:35:57 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1227353002/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1227353002/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode1778 pkg/compiler/lib/src/resolution/members.dart:1778: /// Handle qualified [Send] where the reciever resolves ...
5 years, 5 months ago (2015-07-09 13:42:49 UTC) #3
Johnni Winther
https://codereview.chromium.org/1227353002/diff/1/pkg/compiler/lib/src/resolution/members.dart File pkg/compiler/lib/src/resolution/members.dart (right): https://codereview.chromium.org/1227353002/diff/1/pkg/compiler/lib/src/resolution/members.dart#newcode1778 pkg/compiler/lib/src/resolution/members.dart:1778: /// Handle qualified [Send] where the reciever resolves to ...
5 years, 5 months ago (2015-07-09 13:52:04 UTC) #4
Johnni Winther
5 years, 5 months ago (2015-07-09 14:28:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
6b36c8acc61e54271a47a7b38b2678fba4269eb4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698