Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: tests/compiler/dart2js/diagnose_ambiguous_test.dart

Issue 1227353002: Refactor handling of library prefixes. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Update unittest expectations. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/compiler/dart2js/semantic_visitor_test_send_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/diagnose_ambiguous_test.dart
diff --git a/tests/compiler/dart2js/diagnose_ambiguous_test.dart b/tests/compiler/dart2js/diagnose_ambiguous_test.dart
index c6b3061403e74c25cf0cb96cfb78a445cb80b92a..d70c8e4279d6fbec4b9bf8f9f8a43a61eb0c1102 100644
--- a/tests/compiler/dart2js/diagnose_ambiguous_test.dart
+++ b/tests/compiler/dart2js/diagnose_ambiguous_test.dart
@@ -29,7 +29,7 @@ main() {
diagnosticHandler,
libraryRoot,
packageRoot,
- ['--analyze-only'],
+ ['--analyze-all'],
{});
asyncTest(() => compiler.run(Uri.parse('memory:main.dart')).then((_) {
diagnostics.sort();
@@ -38,10 +38,10 @@ main() {
"memory:library.dart:41:45:'hest' is defined here.:info",
"memory:main.dart:0:22:'hest' is imported here.:info",
"memory:main.dart:23:46:'hest' is imported here.:info",
- "memory:main.dart:86:92:Duplicate import of 'hest'.:error"
+ "memory:main.dart:86:92:Duplicate import of 'hest'.:warning",
];
Expect.listEquals(expected, diagnostics);
- Expect.isTrue(compiler.compilationFailed);
+ Expect.isFalse(compiler.compilationFailed);
}));
}
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/compiler/dart2js/semantic_visitor_test_send_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698