Refactor handling of library prefixes.

tests/compiler/dart2js/semantic_visitor_test_send_data.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor_test;
 
 const Map<String, List<Test>> SEND_TESTS = const {
   'Parameters': const [
     // Parameters
     const Test('m(o) => o;',
@@ skipping 731 matching lines @@
                     element: 'getter(o)')),
     const Test.prefix(
         '''
         get o => null;
         ''',
         '''
         m() => p.o;
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_GET,
                     element: 'getter(o)')),
-    // TODO(johnniwinther): Expect [VISIT_TOP_LEVEL_SETTER_GET] instead.
     const Test(
         '''
         set o(_) {}
         m() => o;
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_GET,
                     element: 'setter(o)')),
     const Test.prefix(
         '''
         set o(_) {}
         ''',
         '''
         m() => p.o;
         ''',
-        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
-                    name: 'o')),
+        const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_GET,
+                    element: 'setter(o)')),
     // TODO(johnniwinther): Expect [VISIT_TOP_LEVEL_GETTER_SET] instead.
     const Test(
         '''
         get o => null;
         m() { o = 42; }
         ''',
         const Visit(VisitKind.VISIT_UNRESOLVED_SET,
                     name: 'o',
                     rhs: '42')),
     const Test.prefix(
@@ skipping 29 matching lines @@
                     element: 'getter(o)',
                     arguments: '(null,42)')),
     const Test.prefix(
         '''
         get o => null;
         ''',
         'm() { p.o(null, 42); }',
         const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_INVOKE,
                     element: 'getter(o)',
                     arguments: '(null,42)')),
-    // TODO(johnniwinther): Expected [VISIT_TOP_LEVEL_SETTER_INVOKE] instead.
     const Test(
         '''
         set o(_) {}
         m() => o(null, 42);
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_INVOKE,
                     element: 'setter(o)',
                     arguments: '(null,42)')),
     const Test.prefix(
         '''
         set o(_) {}
         ''',
         'm() { p.o(null, 42); }',
-        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
-                    name: 'o',
+        const Visit(VisitKind.VISIT_TOP_LEVEL_SETTER_INVOKE,
+                    element: 'setter(o)',
                     arguments: '(null,42)')),
   ],
   'Top level functions': const [
     // Top level functions
     const Test(
         '''
         o(a, b) {}
         m() => o;
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_GET,
@@ skipping 2714 matching lines @@
         '''
         m(a) => a ??= 42;
         ''',
         const Visit(
             VisitKind.VISIT_PARAMETER_COMPOUND,
             element: 'parameter(m#a)',
             operator: '??=',
             rhs: '42')),
   ],
 };