dart2js: In minified mode shorter getter and setter names.

dart2js: In minified mode shorter getter and setter names.

Now a field called x has a getter called gx and a setter called sx in minified
mode.  Previously the getter was get$x and the setter was set$x (as in
unminified code).

This CL also fixed an assert caused by using a getter to access a
variable that is a closure object.

R=karlklose@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=18436

[karlklose, 2013-02-12 14:41:19]

LGTM.

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart
(right):

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart:84: if
(name.startsWith('g')) usedInstanceNames.add(name.substring(1));
Can you use _hasBannedPrefix here?

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart:188: //
Instance members starting with g and s are reserved for getters and
Use /// to turn comment into dart doc.

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart:192: if
(code == $g || code == $s) return true;
'return (code == $g || code == $s)'?

[erikcorry, 2013-02-12 14:50:40]

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart
(right):

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart:84: if
(name.startsWith('g')) usedInstanceNames.add(name.substring(1));
On 2013/02/12 14:41:19, karlklose wrote:
> Can you use _hasBannedPrefix here?

Yes, but the substring(1) still retains implicit knowledge about what the prefix
is (or rather, its length).

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart:188: //
Instance members starting with g and s are reserved for getters and
On 2013/02/12 14:41:19, karlklose wrote:
> Use /// to turn comment into dart doc.

Done.

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart:192: if
(code == $g || code == $s) return true;
On 2013/02/12 14:41:19, karlklose wrote:
> 'return (code == $g || code == $s)'?

Done.

[ngeoffray, 2013-02-12 22:01:53]

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/12250002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:689: if
(member.fieldAccessNeverThrows()) return false;
I'd really prefer to have a "member is ClosureFieldElement" check here instead.
The "fieldAccessNeverThrows" confused me quite a lot, and I don't think it's
something we need on an Element.

https://codereview.chromium.org/12250002/diff/1/tests/compiler/dart2js_native...
File tests/compiler/dart2js_native/native_class_fields_3_test.dart (right):

https://codereview.chromium.org/12250002/diff/1/tests/compiler/dart2js_native...
tests/compiler/dart2js_native/native_class_fields_3_test.dart:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
2011 -> 2013