dart2js: In minified mode shorter getter and setter names.

sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
@@ skipping 176 matching lines @@
     var needsSetter = ${needsSetterCode('lastCharCode')};
     var renaming = ${isRenaming('lastCharCode')};
     var accessorName = field = field.substring(0, len - 1);
     if (renaming) {
       var divider = field.indexOf(":");
       accessorName = field.substring(0, divider);
       field = field.substring(divider + 1);
     }
     if (needsGetter) {
       var getterString = "return this." + field + ";";
-      prototype["get\$" + accessorName] = new Function(getterString);
+      prototype["${namer.getterPrefix}" + accessorName] =
+          new Function(getterString);
     }
     if (needsSetter) {
       var setterString = "this." + field + " = v;";
-      prototype["set\$" + accessorName] = new Function("v", setterString);
+      prototype["${namer.setterPrefix}" + accessorName] =
+          new Function("v", setterString);
     }
   }
   return field;
 }""";
   }
 
   String get defineClassFunction {
     // First the class name, then the field names in an array and the members
     // (inside an Object literal).
     // The caller can also pass in the constructor as a function if needed.
@@ skipping 465 matching lines @@
                                  element.name,
                                  element.getLibrary(),
                                  signature.requiredParameterCount + i,
                                  <SourceString>[]));
     }
     return selectors;
   }
 
   bool instanceFieldNeedsGetter(Element member) {
     assert(member.isField());
+    if (member.fieldAccessNeverThrows()) return false;

[ngeoffray, 2013/02/12 22:01:53]

I'd really prefer to have a "member is ClosureFieldElement" check here instead.
The "fieldAccessNeverThrows" confused me quite a lot, and I don't think it's
something we need on an Element.

     return compiler.codegenWorld.hasInvokedGetter(member, compiler);
   }
 
   bool instanceFieldNeedsSetter(Element member) {
     assert(member.isField());
+    if (member.fieldAccessNeverThrows()) return false;
     return (!member.modifiers.isFinalOrConst())
         && compiler.codegenWorld.hasInvokedSetter(member, compiler);
   }
 
   String compiledFieldName(Element member) {
     assert(member.isField());
     return member.hasFixedBackendName()
         ? member.fixedBackendName()
         : namer.getName(member);
   }
@@ skipping 1714 matching lines @@
 """;
 const String HOOKS_API_USAGE = """
 // The code supports the following hooks:
 // dartPrint(message)   - if this function is defined it is called
 //                        instead of the Dart [print] method.
 // dartMainRunner(main) - if this function is defined, the Dart [main]
 //                        method will not be invoked directly.
 //                        Instead, a closure that will invoke [main] is
 //                        passed to [dartMainRunner].
 """;