Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 12250002: dart2js: In minified mode shorter getter and setter names. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index 09ae310313f1b953b82ba9d4b2f29d49226b3c66..64d0631f12b3d97f775279094d0583dc97465f90 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -194,11 +194,13 @@ function generateAccessor(field, prototype) {
}
if (needsGetter) {
var getterString = "return this." + field + ";";
- prototype["get\$" + accessorName] = new Function(getterString);
+ prototype["${namer.getterPrefix}" + accessorName] =
+ new Function(getterString);
}
if (needsSetter) {
var setterString = "this." + field + " = v;";
- prototype["set\$" + accessorName] = new Function("v", setterString);
+ prototype["${namer.setterPrefix}" + accessorName] =
+ new Function("v", setterString);
}
}
return field;
@@ -684,11 +686,13 @@ $lazyInitializerLogic
bool instanceFieldNeedsGetter(Element member) {
assert(member.isField());
+ if (member.fieldAccessNeverThrows()) return false;
ngeoffray 2013/02/12 22:01:53 I'd really prefer to have a "member is ClosureFiel
return compiler.codegenWorld.hasInvokedGetter(member, compiler);
}
bool instanceFieldNeedsSetter(Element member) {
assert(member.isField());
+ if (member.fieldAccessNeverThrows()) return false;
return (!member.modifiers.isFinalOrConst())
&& compiler.codegenWorld.hasInvokedSetter(member, compiler);
}

Powered by Google App Engine
This is Rietveld 408576698