Hook for overriding the ContextManager and some code clean-up (with more to follow)

Hook for overriding the ContextManager and some code clean-up (with more to follow)

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/0c6872acefbd3455464e24d7b24c3fb24d39efe3

[Brian Wilkerson, 2015-07-09 20:13:40]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2015-07-09 21:45:57]

LGTM.  I don't completely follow where you're going with this, but it doesn't
seem crazy so I'm happy to watch and learn :)

https://codereview.chromium.org/1223413003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1223413003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1173: // TODO(brianwilkerson)
As far as I can tell, this doesn't cause analysis
Ouch.  I believe you are right.

https://codereview.chromium.org/1223413003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1262: class
ContextsChangedEventImpl implements ContextsChangedEvent {
I don't follow the benefit of making an interface/implementation distinction for
this class.  Usually the benefit would be to allow the implementation to be part
of the public API while the implementation remains private.  But since the
plug-in will have to provide an implementation of onContextsChanged, which
returns a stream of ContextsChangedEvent, that means that the plug-in will have
to be able to create concrete instantiations of ContextsChangedEvent.  So both
the implementation and the interface will have to be part of the public API in
order for someone to write a context manager plug-in.

[Brian Wilkerson, 2015-07-13 17:18:50]

https://codereview.chromium.org/1223413003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/1223413003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/analysis_server.dart:1262: class
ContextsChangedEventImpl implements ContextsChangedEvent {
I agree. Done.

[Brian Wilkerson, 2015-07-13 17:20:18]

Committed patchset #1 (id:1) manually as
0c6872acefbd3455464e24d7b24c3fb24d39efe3 (presubmit successful).