Hook for overriding the ContextManager and some code clean-up (with more to follow)

pkg/analysis_server/test/domain_completion_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.completion;
 
 import 'dart:async';
 
 import 'package:analysis_server/completion/completion_core.dart'
     show CompletionRequest;
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/channel/channel.dart';
 import 'package:analysis_server/src/constants.dart';
+import 'package:analysis_server/src/context_manager.dart';
 import 'package:analysis_server/src/domain_analysis.dart';
 import 'package:analysis_server/src/domain_completion.dart';
 import 'package:analysis_server/src/plugin/server_plugin.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/completion_manager.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/index/index.dart' show Index;
 import 'package:analysis_server/src/services/index/local_memory_index.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analysis_server/src/source/optimizing_pub_package_map_provider.dart';
@@ skipping 124 matching lines @@
   /**
    * Assert manager is NOT cleared when context NOT associated with manager changes.
    */
   test_contextsChanged_different() {
     sendRequest(testFile);
     CompletionManager expectedManager;
     return pumpEventQueue().then((_) {
       expect(completionDomain.manager, isNotNull);
       expectedManager = completionDomain.manager;
       completionDomain.contextsChangedRaw(
-          new ContextsChangedEvent(changed: [new MockContext()]));
+          new ContextsChangedEventImpl(changed: [new MockContext()]));
       return pumpEventQueue();
     }).then((_) {
       expect(completionDomain.manager, expectedManager);
     });
   }
 
   /**
    * Assert manager is cleared when context associated with manager changes.
    */
   test_contextsChanged_same() {
     sendRequest(testFile);
     return pumpEventQueue().then((_) {
       expect(completionDomain.manager, isNotNull);
-      completionDomain.contextsChangedRaw(
-          new ContextsChangedEvent(changed: [completionDomain.mockContext]));
+      completionDomain.contextsChangedRaw(new ContextsChangedEventImpl(
+          changed: [completionDomain.mockContext]));
       return pumpEventQueue();
     }).then((_) {
       expect(completionDomain.manager, isNull);
     });
   }
 
   /**
    * Assert manager is cleared when analysis roots are set
    */
   test_setAnalysisRoots() {
@@ skipping 496 matching lines @@
  * so that the domain handler cache management can be tested.
  */
 class Test_CompletionDomainHandler extends CompletionDomainHandler {
   Test_CompletionDomainHandler(Test_AnalysisServer server) : super(server);
 
   MockContext get mockContext => (server as Test_AnalysisServer).mockContext;
 
   MockCompletionManager get mockManager => manager;
 
   void contextsChanged(ContextsChangedEvent event) {
-    contextsChangedRaw(new ContextsChangedEvent(
+    contextsChangedRaw(new ContextsChangedEventImpl(
         added: event.added.length > 0 ? [mockContext] : [],
         changed: event.changed.length > 0 ? [mockContext] : [],
         removed: event.removed.length > 0 ? [mockContext] : []));
   }
 
   void contextsChangedRaw(ContextsChangedEvent newEvent) {
     super.contextsChanged(newEvent);
   }
 
   CompletionManager createCompletionManager(
@@ skipping 18 matching lines @@
 }
     ''');
     await waitForTasksFinished();
     Request request =
         new CompletionGetSuggestionsParams(testFile, 0).toRequest('0');
     Response response = handler.handleRequest(request);
     expect(response.error, isNotNull);
     expect(response.error.code, RequestErrorCode.NO_INDEX_GENERATED);
   }
 }