pkg/analysis_server/test/domain_completion_test.dart - Issue 1223413003: Hook for overriding the ContextManager and some code clean-up (with more to follow)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 1223413003: Hook for overriding the ContextManager and some code clean-up (with more to follow) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/analysis_server.dart ('K') | « pkg/analysis_server/test/context_manager_test.dart ('k') | pkg/analysis_server/test/domain_execution_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/domain_completion_test.dart

diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart

index a51cdec8ce5cdcdee8367e047529605196fc197d..79687cb45b82a02f0b0e2f034b77e34c29fb2212 100644

--- a/pkg/analysis_server/test/domain_completion_test.dart

+++ b/pkg/analysis_server/test/domain_completion_test.dart

@@ -11,6 +11,7 @@ import 'package:analysis_server/completion/completion_core.dart'

import 'package:analysis_server/src/analysis_server.dart';

import 'package:analysis_server/src/channel/channel.dart';

import 'package:analysis_server/src/constants.dart';

+import 'package:analysis_server/src/context_manager.dart';

import 'package:analysis_server/src/domain_analysis.dart';

import 'package:analysis_server/src/domain_completion.dart';

import 'package:analysis_server/src/plugin/server_plugin.dart';

@@ -155,7 +156,7 @@ class CompletionManagerTest extends AbstractAnalysisTest {

expect(completionDomain.manager, isNotNull);

expectedManager = completionDomain.manager;

completionDomain.contextsChangedRaw(

- new ContextsChangedEvent(changed: [new MockContext()]));

+ new ContextsChangedEventImpl(changed: [new MockContext()]));

return pumpEventQueue();

}).then((_) {

expect(completionDomain.manager, expectedManager);

@@ -169,8 +170,8 @@ class CompletionManagerTest extends AbstractAnalysisTest {

sendRequest(testFile);

return pumpEventQueue().then((_) {

expect(completionDomain.manager, isNotNull);

- completionDomain.contextsChangedRaw(

- new ContextsChangedEvent(changed: [completionDomain.mockContext]));

+ completionDomain.contextsChangedRaw(new ContextsChangedEventImpl(

+ changed: [completionDomain.mockContext]));

return pumpEventQueue();

}).then((_) {

expect(completionDomain.manager, isNull);

@@ -687,7 +688,7 @@ class Test_CompletionDomainHandler extends CompletionDomainHandler {

MockCompletionManager get mockManager => manager;

void contextsChanged(ContextsChangedEvent event) {

- contextsChangedRaw(new ContextsChangedEvent(

+ contextsChangedRaw(new ContextsChangedEventImpl(

added: event.added.length > 0 ? [mockContext] : [],

changed: event.changed.length > 0 ? [mockContext] : [],

removed: event.removed.length > 0 ? [mockContext] : []));