Intrinsic version of Object.runtimeType

Intrinsic version of Object.runtimeType

BUG=
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/c0b359db6cec752f1d91b495d69e0df7b984d9a7

[srdjan, 2015-06-30 23:12:46]

srdjan@google.com changed reviewers:
+ regis@google.com

[srdjan, 2015-06-30 23:12:47]

RFC

Only ia32 and x64 versions have been completed. Changes for other architectures
will be uploaded soon. 

Let me know if you see any problems.

[regis, 2015-06-30 23:26:59]

On 2015/06/30 23:12:47, srdjan wrote:
> RFC
> 
> Only ia32 and x64 versions have been completed. Changes for other
architectures
> will be uploaded soon. 
> 
> Let me know if you see any problems.

Looks good so far.

[regis, 2015-06-30 23:28:32]

Looks good so far.

Just replying does not send comments. Here they are.

Thanks!

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_arm.cc
File runtime/vm/intrinsifier_arm.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_arm...
runtime/vm/intrinsifier_arm.cc:1573: // Return type quickly for non-paramtrized
types.
paramtrized -> parameterized

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_arm...
File runtime/vm/intrinsifier_arm64.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_arm...
runtime/vm/intrinsifier_arm64.cc:1649: // Return type quickly for
non-paramtrized types.
ditto

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_ia3...
File runtime/vm/intrinsifier_ia32.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_ia3...
runtime/vm/intrinsifier_ia32.cc:1669: // Return type quickly for simple types
(not parametrized and not signature)
parametrized ->  parameterized

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_ia3...
runtime/vm/intrinsifier_ia32.cc:1679: __ LoadClass(EBX, EAX, EDI);
The C++ code explicitly checks for a null instance, but if the class is
correctly set for null instances, we are OK without checking.

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_ia3...
runtime/vm/intrinsifier_ia32.cc:1683: // }
I would remove the code in the comment.

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_mip...
File runtime/vm/intrinsifier_mips.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_mip...
runtime/vm/intrinsifier_mips.cc:1678: // Return type quickly for non-paramtrized
types.
ditto

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_x64.cc
File runtime/vm/intrinsifier_x64.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_x64...
runtime/vm/intrinsifier_x64.cc:1527: // Return type quickly for simple types
(not parametrized and not signature)
ditto

[srdjan, 2015-07-01 00:35:41]

All architectures implemented, slight refactoring of code. This CL is ready for
full review.

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_arm.cc
File runtime/vm/intrinsifier_arm.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_arm...
runtime/vm/intrinsifier_arm.cc:1573: // Return type quickly for non-paramtrized
types.
On 2015/06/30 23:28:32, regis wrote:
> paramtrized -> parameterized

Comment will be replaced once implemented.

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_arm...
File runtime/vm/intrinsifier_arm64.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_arm...
runtime/vm/intrinsifier_arm64.cc:1649: // Return type quickly for
non-paramtrized types.
On 2015/06/30 23:28:32, regis wrote:
> ditto

ditto

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_ia3...
File runtime/vm/intrinsifier_ia32.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_ia3...
runtime/vm/intrinsifier_ia32.cc:1669: // Return type quickly for simple types
(not parametrized and not signature)
On 2015/06/30 23:28:32, regis wrote:
> parametrized ->  parameterized

Done.

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_ia3...
runtime/vm/intrinsifier_ia32.cc:1679: __ LoadClass(EBX, EAX, EDI);
On 2015/06/30 23:28:32, regis wrote:
> The C++ code explicitly checks for a null instance, but if the class is
> correctly set for null instances, we are OK without checking.

Added a test. The explicit check is probably in C++ is probably for performance
reasons.

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_ia3...
runtime/vm/intrinsifier_ia32.cc:1683: // }
On 2015/06/30 23:28:32, regis wrote:
> I would remove the code in the comment.

Done.

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_mip...
File runtime/vm/intrinsifier_mips.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_mip...
runtime/vm/intrinsifier_mips.cc:1678: // Return type quickly for non-paramtrized
types.
On 2015/06/30 23:28:32, regis wrote:
> ditto

Will be replaced once implemented.

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_x64.cc
File runtime/vm/intrinsifier_x64.cc (right):

https://codereview.chromium.org/1217323002/diff/1/runtime/vm/intrinsifier_x64...
runtime/vm/intrinsifier_x64.cc:1527: // Return type quickly for simple types
(not parametrized and not signature)
On 2015/06/30 23:28:32, regis wrote:
> ditto

ditto

[regis, 2015-07-01 01:45:56]

lgtm

https://codereview.chromium.org/1217323002/diff/20001/tests/language/runtime_...
File tests/language/runtime_type_test.dart (right):

https://codereview.chromium.org/1217323002/diff/20001/tests/language/runtime_...
tests/language/runtime_type_test.dart:13: Expect.isTrue(null.runtimeType is
Type);
Great. You could also add
null.runtimeType is Null
since Null is the type of null.

Note however that 'null is Null' is true, so do not just replace Type with Null,
in case null.runtimeType evaluates to null by error.
('null is Type' would fail in that case).

[srdjan, 2015-07-01 16:15:39]

https://codereview.chromium.org/1217323002/diff/20001/tests/language/runtime_...
File tests/language/runtime_type_test.dart (right):

https://codereview.chromium.org/1217323002/diff/20001/tests/language/runtime_...
tests/language/runtime_type_test.dart:13: Expect.isTrue(null.runtimeType is
Type);
On 2015/07/01 01:45:56, regis wrote:
> Great. You could also add
> null.runtimeType is Null
> since Null is the type of null.
> 
> Note however that 'null is Null' is true, so do not just replace Type with
Null,
> in case null.runtimeType evaluates to null by error.
> ('null is Type' would fail in that case).
> 
>  

'null.runtimeType is Null' is always false. Instead added:
Expect.equals(null.runtimeType, Null);

[regis, 2015-07-01 16:27:19]

On 2015/07/01 16:15:39, srdjan wrote:
>
https://codereview.chromium.org/1217323002/diff/20001/tests/language/runtime_...
> File tests/language/runtime_type_test.dart (right):
> 
>
https://codereview.chromium.org/1217323002/diff/20001/tests/language/runtime_...
> tests/language/runtime_type_test.dart:13: Expect.isTrue(null.runtimeType is
> Type);
> On 2015/07/01 01:45:56, regis wrote:
> > Great. You could also add
> > null.runtimeType is Null
> > since Null is the type of null.
> > 
> > Note however that 'null is Null' is true, so do not just replace Type with
> Null,
> > in case null.runtimeType evaluates to null by error.
> > ('null is Type' would fail in that case).
> > 
> >  
> 
> 'null.runtimeType is Null' is always false. Instead added:
> Expect.equals(null.runtimeType, Null);

My bad. Yes, 'x is Null' is only true if is a null instance.

[srdjan, 2015-07-01 17:13:26]

Committed patchset #2 (id:20001) manually as
c0b359db6cec752f1d91b495d69e0df7b984d9a7 (presubmit successful).