tests/language/runtime_type_test.dart - Issue 1217323002: Intrinsic version of Object.runtimeType

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/language/runtime_type_test.dart

Issue 1217323002: Intrinsic version of Object.runtimeType (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: more Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 import "package:expect/expect.dart";	5 import "package:expect/expect.dart";

6	6

7 class A {	7 class A {

8 get className => runtimeType;	8 get className => runtimeType;

9 }	9 }

10	10

11 main() {	11 main() {

12 Expect.isTrue(new A().className is Type);	12 Expect.isTrue(new A().className is Type);

	13 Expect.isTrue(null.runtimeType is Type);
	regis 2015/07/01 01:45:56 Great. You could also add null.runtimeType is Null Great. You could also add null.runtimeType is Null since Null is the type of null. Note however that 'null is Null' is true, so do not just replace Type with Null, in case null.runtimeType evaluates to null by error. ('null is Type' would fail in that case). srdjan 2015/07/01 16:15:39 'null.runtimeType is Null' is always false. Instea Show quoted text On 2015/07/01 01:45:56, regis wrote: > Great. You could also add > null.runtimeType is Null > since Null is the type of null. > > Note however that 'null is Null' is true, so do not just replace Type with Null, > in case null.runtimeType evaluates to null by error. > ('null is Type' would fail in that case). > > 'null.runtimeType is Null' is always false. Instead added: Expect.equals(null.runtimeType, Null);
13 }	14 }

OLD	NEW

« no previous file with comments | « runtime/vm/raw_object.h ('k') | no next file » | no next file with comments »