Intrinsic version of Object.runtimeType

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 1648 matching lines @@
   __ cmpl(EAX, Address(ESP, + 2 * kWordSize));
   __ j(EQUAL, &is_true, Assembler::kNearJump);
   __ LoadObject(EAX, Bool::False());
   __ ret();
   __ Bind(&is_true);
   __ LoadObject(EAX, Bool::True());
   __ ret();
 }
 
 
+// Return type quickly for simple types (not parametrized and not signature)

[regis, 2015/06/30 23:28:32]

parametrized ->  parameterized

[srdjan, 2015/07/01 00:35:41]

Done.

+void Intrinsifier::ObjectRuntimeType(Assembler* assembler) {
+  Label fall_through, not_smi;
+  __ movl(EAX, Address(ESP, + 1 * kWordSize));
+  __ testl(EAX, Immediate(kSmiTagMask));
+  __ j(NOT_ZERO, &not_smi, Assembler::kNearJump);
+  __ LoadObject(EAX, Type::ZoneHandle(Type::IntType()));
+  __ ret();
+
+  __ Bind(&not_smi);
+  __ LoadClass(EBX, EAX, EDI);

[regis, 2015/06/30 23:28:32]

The C++ code explicitly checks for a null instance, but if the class is
correctly set for null instances, we are OK without checking.

[srdjan, 2015/07/01 00:35:41]

Added a test. The explicit check is probably in C++ is probably for performance
reasons.

+  // EBX: class of instance (EAX).
+  // if ((NumTypeArguments() == 0) && !IsSignatureClass()) {
+  //   return reinterpret_cast<RawType*>(raw_ptr()->canonical_types_);
+  // }

[regis, 2015/06/30 23:28:32]

I would remove the code in the comment.

[srdjan, 2015/07/01 00:35:41]

Done.

+  const Immediate& raw_null =
+      Immediate(reinterpret_cast<intptr_t>(Object::null()));
+  __ movl(EDI, FieldAddress(EBX, Class::signature_function_offset()));
+  __ cmpl(EDI, raw_null);
+  __ j(NOT_EQUAL, &fall_through, Assembler::kNearJump);
+
+  __ movzxw(EDI, FieldAddress(EBX, Class::num_type_arguments_offset()));
+  __ cmpl(EDI, Immediate(0));
+  __ j(NOT_EQUAL, &fall_through, Assembler::kNearJump);
+  __ movl(EAX, FieldAddress(EBX, Class::canonical_types_offset()));
+  __ cmpl(EAX, raw_null);
+  __ j(EQUAL, &fall_through, Assembler::kNearJump);  // Not yet set.
+  __ ret();
+
+  __ Bind(&fall_through);
+}
+
+
 void Intrinsifier::String_getHashCode(Assembler* assembler) {
   Label fall_through;
   __ movl(EAX, Address(ESP, + 1 * kWordSize));  // String object.
   __ movl(EAX, FieldAddress(EAX, String::hash_offset()));
   __ cmpl(EAX, Immediate(0));
   __ j(EQUAL, &fall_through, Assembler::kNearJump);
   __ ret();
   __ Bind(&fall_through);
   // Hash not yet computed.
 }
@@ skipping 387 matching lines @@
   __ movl(EBX, Address(ESP, kRegExpParamOffset));
   __ movl(EDI, Address(ESP, kStringParamOffset));
   __ LoadClassId(EDI, EDI);
   __ SubImmediate(EDI, Immediate(kOneByteStringCid));
   __ movl(EAX, FieldAddress(EBX, EDI, TIMES_4,
                             JSRegExp::function_offset(kOneByteStringCid)));
 
   // Registers are now set up for the lazy compile stub. It expects the function
   // in EAX, the argument descriptor in EDX, and IC-Data in ECX.
   static const intptr_t arg_count = RegExpMacroAssembler::kParamCount;
-  __ LoadObject(EDX, Array::Handle(ArgumentsDescriptor::New(arg_count)));
+  __ LoadObject(EDX, Array::ZoneHandle(ArgumentsDescriptor::New(arg_count)));
   __ xorl(ECX, ECX);
 
   // Tail-call the function.
   __ movl(EDI, FieldAddress(EAX, Function::instructions_offset()));
   __ addl(EDI, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
   __ jmp(EDI);
 }
 
 
 // On stack: user tag (+1), return-address (+0).
@@ skipping 37 matching lines @@
                         Isolate::current_tag_offset());
   // Set return value to Isolate::current_tag_.
   __ movl(EAX, current_tag_addr);
   __ ret();
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32