Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 12093071: - Change the layout of external typed array objects to avoid the extra indirection when accessing e… (Closed)

Created:
7 years, 10 months ago by siva
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Change the layout of external typed array objects to avoid the extra indirection when accessing elements in the array. - Change the Dart API which create these external arrays to account for this change Committed: https://code.google.com/p/dart/source/detail?r=17937

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -377 lines) Patch
M runtime/bin/dartutils.h View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/bin/dartutils.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M runtime/bin/io_buffer.h View 2 chunks +11 lines, -3 lines 0 comments Download
M runtime/bin/io_buffer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/include/dart_api.h View 3 chunks +13 lines, -8 lines 0 comments Download
M runtime/lib/byte_array.cc View 1 13 chunks +74 lines, -77 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +12 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/object.h View 26 chunks +134 lines, -116 lines 0 comments Download
M runtime/vm/object.cc View 1 2 21 chunks +55 lines, -78 lines 0 comments Download
M runtime/vm/object_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/raw_object.h View 2 chunks +21 lines, -43 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
Anton: There are changes to the API with regards to Dart_NewExternalByteArray and Dart_NewExternalClampedByteArray (takes Dart_WeakPersistentHandleFinalizer ...
7 years, 10 months ago (2013-01-30 22:31:33 UTC) #1
srdjan
lgtm
7 years, 10 months ago (2013-01-30 23:13:46 UTC) #2
Søren Gjesse
7 years, 10 months ago (2013-01-31 08:08:33 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698