- Change the layout of external typed array objects to avoid the extra indirection when accessing e…

runtime/vm/object_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
@@ skipping 1887 matching lines @@
 }
 
 
 TEST_CASE(ExternalByteArray) {
   uint8_t data[] = { 253, 254, 255, 0, 1, 2, 3, 4 };
   intptr_t data_length = ARRAY_SIZE(data);
 
   const ExternalInt8Array& int8_array =
       ExternalInt8Array::Handle(
           ExternalInt8Array::New(reinterpret_cast<int8_t*>(data),
-                                 data_length, NULL, NULL));
+                                 data_length));
   EXPECT(!int8_array.IsNull());
   EXPECT_EQ(data_length, int8_array.Length());
 
   const ExternalUint8Array& uint8_array =
       ExternalUint8Array::Handle(
-          ExternalUint8Array::New(data, data_length, NULL, NULL));
+          ExternalUint8Array::New(data, data_length));
   EXPECT(!uint8_array.IsNull());
   EXPECT_EQ(data_length, uint8_array.Length());
 
   const ExternalUint8ClampedArray& uint8_clamped_array =
       ExternalUint8ClampedArray::Handle(
-          ExternalUint8ClampedArray::New(data, data_length, NULL, NULL));
+          ExternalUint8ClampedArray::New(data, data_length));
   EXPECT(!uint8_clamped_array.IsNull());
   EXPECT_EQ(data_length, uint8_clamped_array.Length());
 
   EXPECT_EQ(-3, int8_array.At(0));
   EXPECT_EQ(253, uint8_array.At(0));
   EXPECT_EQ(253, uint8_clamped_array.At(0));
 
   EXPECT_EQ(-2, int8_array.At(1));
   EXPECT_EQ(254, uint8_array.At(1));
   EXPECT_EQ(254, uint8_clamped_array.At(1));
@@ skipping 152 matching lines @@
 
 
 TEST_CASE(Uint8ByteArrayCopyExternal) {
   const uint8_t b_0_1_2_3[] = { 0, 1, 2, 3 };
   const uint8_t b_4_5_6_7[] = { 4, 5, 6, 7 };
 
   uint8_t data[] = { 0, 1, 2, 3 };
 
   const ExternalUint8Array& external =
       ExternalUint8Array::Handle(
-          ExternalUint8Array::New(data, ARRAY_SIZE(data), NULL, NULL));
+          ExternalUint8Array::New(data, ARRAY_SIZE(data)));
   EXPECT(!external.IsNull());
   EXPECT_EQ(4, external.Length());
   EXPECT_EQ(0, external.At(0));
   EXPECT_EQ(1, external.At(1));
   EXPECT_EQ(2, external.At(2));
   EXPECT_EQ(3, external.At(3));
 
   // A zero length copy.
   ByteArray::Copy(external, 0, b_4_5_6_7, 0);
   EXPECT_EQ(0, external.At(0));
@@ skipping 39 matching lines @@
 
 
 TEST_CASE(ClampedUint8ByteArrayCopyExternal) {
   const uint8_t b_0_1_2_3[] = { 0, 1, 2, 3 };
   const uint8_t b_4_5_6_7[] = { 4, 5, 6, 7 };
 
   uint8_t data[] = { 0, 1, 2, 3 };
 
   const ExternalUint8ClampedArray& external =
       ExternalUint8ClampedArray::Handle(
-          ExternalUint8ClampedArray::New(data, ARRAY_SIZE(data), NULL, NULL));
+          ExternalUint8ClampedArray::New(data, ARRAY_SIZE(data)));
   EXPECT(!external.IsNull());
   EXPECT_EQ(4, external.Length());
   EXPECT_EQ(0, external.At(0));
   EXPECT_EQ(1, external.At(1));
   EXPECT_EQ(2, external.At(2));
   EXPECT_EQ(3, external.At(3));
 
   // A zero length copy.
   ByteArray::Copy(external, 0, b_4_5_6_7, 0);
   EXPECT_EQ(0, external.At(0));
@@ skipping 46 matching lines @@
       Uint8Array::Handle(Uint8Array::New(b_0_1_2_3, ARRAY_SIZE(b_0_1_2_3)));
   EXPECT(!internal.IsNull());
   EXPECT_EQ(4, internal.Length());
   EXPECT_EQ(0, internal.At(0));
   EXPECT_EQ(1, internal.At(1));
   EXPECT_EQ(2, internal.At(2));
   EXPECT_EQ(3, internal.At(3));
 
   const ExternalUint8Array& external =
       ExternalUint8Array::Handle(
-          ExternalUint8Array::New(data, ARRAY_SIZE(data), NULL, NULL));
+          ExternalUint8Array::New(data, ARRAY_SIZE(data)));
   EXPECT(!external.IsNull());
   EXPECT_EQ(4, external.Length());
   EXPECT_EQ(4, external.At(0));
   EXPECT_EQ(5, external.At(1));
   EXPECT_EQ(6, external.At(2));
   EXPECT_EQ(7, external.At(3));
 
   // A zero length copy.
   ByteArray::Copy(internal, 0, external, 0, 0);
   EXPECT_EQ(0, internal.At(0));
@@ skipping 60 matching lines @@
           Uint8ClampedArray::New(b_0_1_2_3, ARRAY_SIZE(b_0_1_2_3)));
   EXPECT(!internal.IsNull());
   EXPECT_EQ(4, internal.Length());
   EXPECT_EQ(0, internal.At(0));
   EXPECT_EQ(1, internal.At(1));
   EXPECT_EQ(2, internal.At(2));
   EXPECT_EQ(3, internal.At(3));
 
   const ExternalUint8ClampedArray& external =
       ExternalUint8ClampedArray::Handle(
-          ExternalUint8ClampedArray::New(data, ARRAY_SIZE(data), NULL, NULL));
+          ExternalUint8ClampedArray::New(data, ARRAY_SIZE(data)));
   EXPECT(!external.IsNull());
   EXPECT_EQ(4, external.Length());
   EXPECT_EQ(4, external.At(0));
   EXPECT_EQ(5, external.At(1));
   EXPECT_EQ(6, external.At(2));
   EXPECT_EQ(7, external.At(3));
 
   // A zero length copy.
   ByteArray::Copy(internal, 0, external, 0, 0);
   EXPECT_EQ(0, internal.At(0));
@@ skipping 1274 matching lines @@
   EXPECT_NE(test1.SourceFingerprint(), test3.SourceFingerprint());
   EXPECT_NE(test3.SourceFingerprint(), test4.SourceFingerprint());
   EXPECT_NE(test4.SourceFingerprint(), test5.SourceFingerprint());
   EXPECT_NE(test5.SourceFingerprint(), test6.SourceFingerprint());
   EXPECT_EQ(test6.SourceFingerprint(), test7.SourceFingerprint());
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart