runtime/vm/intrinsifier_ia32.cc - Issue 12093071: - Change the layout of external typed array objects to avoid the extra indirection when accessing e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 12093071: - Change the layout of external typed array objects to avoid the extra indirection when accessing e… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_ia32.cc

===================================================================

--- runtime/vm/intrinsifier_ia32.cc (revision 17875)

+++ runtime/vm/intrinsifier_ia32.cc (working copy)

@@ -978,8 +978,7 @@

// EBX: index as Smi.

// EAX: array.

__ SmiUntag(EBX);

- __ movl(EAX, FieldAddress(EAX, ExternalUint8Array::external_data_offset()));

- __ movl(EAX, Address(EAX, ExternalByteArrayData<uint8_t>::data_offset()));

+ __ movl(EAX, FieldAddress(EAX, ExternalUint8Array::data_offset()));

__ movzxb(EAX, Address(EAX, EBX, TIMES_1, 0));

__ SmiTag(EAX);

__ ret();

« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | no next file with comments »