Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 12089081: Fix Safari "multitest" failure. (Closed)

Created:
7 years, 10 months ago by Emily Fortuna
Modified:
7 years, 10 months ago
Reviewers:
ricow1, kustermann, blois
CC:
reviews_dartlang.org, ricow1, kustermann
Visibility:
Public.

Description

Fix Safari "multitest" failure. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17882

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M pkg/unittest/lib/html_individual_config.dart View 1 chunk +9 lines, -4 lines 1 comment Download
M tests/html/html.status View 1 1 chunk +0 lines, -14 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
So the current system of selenium testing uses a combination of both WebDriver (the new ...
7 years, 10 months ago (2013-01-30 23:14:09 UTC) #1
blois
lgtm
7 years, 10 months ago (2013-01-30 23:25:29 UTC) #2
kustermann
DBC https://codereview.chromium.org/12089081/diff/4001/pkg/unittest/lib/html_individual_config.dart File pkg/unittest/lib/html_individual_config.dart (right): https://codereview.chromium.org/12089081/diff/4001/pkg/unittest/lib/html_individual_config.dart#newcode28 pkg/unittest/lib/html_individual_config.dart:28: var groupVar = '&group='; I'd prefer something like: ...
7 years, 10 months ago (2013-01-31 00:07:01 UTC) #3
ricow1
7 years, 10 months ago (2013-01-31 07:17:24 UTC) #4
Message was sent while issue was closed.
Awesome, thanks a lot Emily

Powered by Google App Engine
This is Rietveld 408576698