Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: pkg/unittest/lib/html_individual_config.dart

Issue 12089081: Fix Safari "multitest" failure. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * A unit test library for running groups of tests in a browser, instead of the 6 * A unit test library for running groups of tests in a browser, instead of the
7 * entire test file. This is especially used for large tests files that have 7 * entire test file. This is especially used for large tests files that have
8 * many subtests, so we can mark groups as failing at a finer granularity than 8 * many subtests, so we can mark groups as failing at a finer granularity than
9 * the entire test file. 9 * the entire test file.
10 * 10 *
11 * To use, import this file, and call [useHtmlIndividualConfiguration] at the 11 * To use, import this file, and call [useHtmlIndividualConfiguration] at the
12 * start of your set sequence. Important constraint: your group descriptions 12 * start of your set sequence. Important constraint: your group descriptions
13 * MUST NOT contain spaces. 13 * MUST NOT contain spaces.
14 */ 14 */
15 library unittest_html_individual_config; 15 library unittest_html_individual_config;
16 16
17 import 'dart:html'; 17 import 'dart:html';
18 import 'unittest.dart' as unittest; 18 import 'unittest.dart' as unittest;
19 import 'html_config.dart' as htmlconfig; 19 import 'html_config.dart' as htmlconfig;
20 20
21 class HtmlIndividualConfiguration extends htmlconfig.HtmlConfiguration { 21 class HtmlIndividualConfiguration extends htmlconfig.HtmlConfiguration {
22 22
23 String _noSuchTest = ''; 23 String _noSuchTest = '';
24 HtmlIndividualConfiguration(isLayoutTest): super(isLayoutTest); 24 HtmlIndividualConfiguration(isLayoutTest): super(isLayoutTest);
25 25
26 void onStart() { 26 void onStart() {
27 var testGroupName = window.location.hash; 27 var testGroupName = window.location.search;
28 if (testGroupName != '') { 28 var groupVar = '&group=';
kustermann 2013/01/31 00:07:01 I'd prefer something like: for (var getParameter i
29 if (testGroupName != '' && testGroupName.contains(groupVar)) {
29 try { 30 try {
30 testGroupName = testGroupName.substring(1); // cut off the # 31 testGroupName = testGroupName.substring(
31 unittest.filterTests('^$testGroupName'); 32 testGroupName.indexOf(groupVar) + groupVar.length);
33 var endIndex = testGroupName.indexOf('&');
34 testGroupName = testGroupName.substring(0,
35 endIndex == -1 ? testGroupName.length : endIndex);
36 unittest.filterTests('^$testGroupName${unittest.groupSep}');
32 } catch (e) { 37 } catch (e) {
33 print('tried to match "$testGroupName"'); 38 print('tried to match "$testGroupName"');
34 print('NO_SUCH_TEST'); 39 print('NO_SUCH_TEST');
35 } 40 }
36 } 41 }
37 super.onStart(); 42 super.onStart();
38 } 43 }
39 } 44 }
40 45
41 void useHtmlIndividualConfiguration([bool isLayoutTest = false]) { 46 void useHtmlIndividualConfiguration([bool isLayoutTest = false]) {
42 if (unittest.config != null) return; 47 if (unittest.config != null) return;
43 unittest.configure(new HtmlIndividualConfiguration(isLayoutTest)); 48 unittest.configure(new HtmlIndividualConfiguration(isLayoutTest));
44 } 49 }
OLDNEW
« no previous file with comments | « no previous file | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698