Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 12089081: Fix Safari "multitest" failure. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/unittest/lib/html_individual_config.dart ('K') | « tests/html/html.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index f19eccf4964727ae553071e6558582290bb7f15c..349a8a632a638f46211aaa4d86d36b7561979aed 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -970,6 +970,7 @@ class StandardTestSuite extends TestSuite {
htmlPath = htmlPath.startsWith(basePath) ?
htmlPath.substring(basePath.length) : htmlPath;
String fullHtmlPath = htmlPath;
+ var searchStr = '?';
if (!htmlPath.startsWith('http')) {
// Note: If we run test.py with the "--list" option, no http servers
// will be started. Therefore serverList is an empty list in this
@@ -980,12 +981,14 @@ class StandardTestSuite extends TestSuite {
serverPort = serverList[0].port.toString();
crossOriginPort = serverList[1].port.toString();
}
- fullHtmlPath = 'http://127.0.0.1:$serverPort$htmlPath?'
+ fullHtmlPath = 'http://127.0.0.1:$serverPort$htmlPath${searchStr}'
'crossOriginPort=$crossOriginPort';
+ searchStr = '&';
}
if (info.optionsFromFile['isMultiHtmlTest']
&& subtestNames.length > 0) {
- fullHtmlPath = '${fullHtmlPath}#${subtestNames[subtestIndex]}';
+ fullHtmlPath = '${fullHtmlPath}${searchStr}group='
+ '${subtestNames[subtestIndex]}';
}
if (TestUtils.usesWebDriver(runtime)) {
« pkg/unittest/lib/html_individual_config.dart ('K') | « tests/html/html.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698