Issue 12087052: Implement Types.isSubtype for FunctionType with optional and named parameters.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+321 lines, -13 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View	1 2 3 4	5 chunks	+65 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/util/link.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/util/link_implementation.dart	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2	3 chunks	+1 line, -4 lines	0 comments	Download
M	tests/compiler/dart2js/type_checker_test.dart	View	1 2 3 4	2 chunks	+126 lines, -1 line	0 comments	Download
A	tests/language/typedef_is_test.dart	View	1	1 chunk	+123 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM, with comments. I prefer shorter names if you have pairs like sSomething and tSomething, ...

7 years, 10 months ago (2013-01-30 09:39:12 UTC) #2

Johnni Winther

7 years, 10 months ago (2013-01-30 10:26:57 UTC) #3

https://codereview.chromium.org/12087052/diff/6001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/12087052/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/typechecker.dart:737: // Since named
parameters are globally ordered we can determine subset
On 2013/01/30 09:39:12, karlklose wrote:
> 'determine subset *relation* *with*'?

Done.

https://codereview.chromium.org/12087052/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/typechecker.dart:740:
Link<SourceString> tNamedParameter = tf.namedParameters;
On 2013/01/30 09:39:12, karlklose wrote:
> 'tNames'?

Done.

https://codereview.chromium.org/12087052/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/typechecker.dart:741: Link<DartType>
tNamedParameterType = tf.namedParameterTypes;
On 2013/01/30 09:39:12, karlklose wrote:
> 'tTypes'?

Done.

https://codereview.chromium.org/12087052/diff/6001/tests/compiler/dart2js/typ...
File tests/compiler/dart2js/type_checker_test.dart (right):

https://codereview.chromium.org/12087052/diff/6001/tests/compiler/dart2js/typ...
tests/compiler/dart2js/type_checker_test.dart:476: expect(false, [], {}, [],
{'a': intType});
On 2013/01/30 09:39:12, karlklose wrote:
> That should be
>   expect(false, [intType], {}, [], {'a': intType});
> shouldn't it?

Done.

Expand Messages | Collapse Messages