sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 12087052: Implement Types.isSubtype for FunctionType with optional and named parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 12087052: Implement Types.isSubtype for FunctionType with optional and named parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebased (again) Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_types.dart ('k') | sdk/lib/_internal/compiler/implementation/typechecker.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index 0db6f367d979850187f7892f6cfca0a4e1651f15..bc9081324c0d69d188c02d8720c795e2460056ce 100644

--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -848,12 +848,12 @@ class ResolverTask extends CompilerTask {

if (signature.optionalParametersAreNamed) {

var namedParametersBuilder = new LinkBuilder<SourceString>();

var namedParameterTypesBuilder = new LinkBuilder<DartType>();

- for (Element parameter in signature.optionalParameters) {

+ for (Element parameter in signature.orderedOptionalParameters) {

namedParametersBuilder.addLast(parameter.name);

namedParameterTypesBuilder.addLast(parameter.computeType(compiler));

}

namedParameters = namedParametersBuilder.toLink();

- namedParameterTypes = namedParametersBuilder.toLink();

+ namedParameterTypes = namedParameterTypesBuilder.toLink();

} else {

var optionalParameterTypesBuilder = new LinkBuilder<DartType>();

for (Element parameter in signature.optionalParameters) {