Implement Types.isSubtype for FunctionType with optional and named parameters.

sdk/lib/_internal/compiler/implementation/resolution/members.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of resolution;
 
 abstract class TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   DartType getType(Node node);
@@ skipping 830 matching lines @@
     var parameterTypes = new LinkBuilder<DartType>();
     for (Element parameter in signature.requiredParameters) {
        parameterTypes.addLast(parameter.computeType(compiler));
     }
     var optionalParameterTypes = const Link<DartType>();
     var namedParameters = const Link<SourceString>();
     var namedParameterTypes = const Link<DartType>();
     if (signature.optionalParametersAreNamed) {
       var namedParametersBuilder = new LinkBuilder<SourceString>();
       var namedParameterTypesBuilder = new LinkBuilder<DartType>();
-      for (Element parameter in signature.optionalParameters) {
+      for (Element parameter in signature.orderedOptionalParameters) {
         namedParametersBuilder.addLast(parameter.name);
         namedParameterTypesBuilder.addLast(parameter.computeType(compiler));
       }
       namedParameters = namedParametersBuilder.toLink();
-      namedParameterTypes = namedParametersBuilder.toLink();
+      namedParameterTypes = namedParameterTypesBuilder.toLink();
     } else {
       var optionalParameterTypesBuilder = new LinkBuilder<DartType>();
       for (Element parameter in signature.optionalParameters) {
         optionalParameterTypesBuilder.addLast(parameter.computeType(compiler));
       }
       optionalParameterTypes = optionalParameterTypesBuilder.toLink();
     }
     return new FunctionType(element,
         signature.returnType,
         parameterTypes.toLink(),
@@ skipping 2756 matching lines @@
     return e;
   }
 
   /// Assumed to be called by [resolveRedirectingFactory].
   Element visitReturn(Return node) {
     Node expression = node.expression;
     return finishConstructorReference(visit(expression),
                                       expression, expression);
   }
 }