Issue 1203773002: Disable guessing 'other' cid; this prevents an issue in range analysis. It is not clear if guessing…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1203773002: Disable guessing 'other' cid; this prevents an issue in range analysis. It is not clear if guessing… (Closed)

Created:
5 years, 6 months ago by srdjan

Modified:
5 years, 6 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Disable guessing 'other' cid; this prevents an issue in range analysis. It is not clear if guessing the 'other' cid optimization is the right thing to do as it may bring the flow graph in an unexpected state BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/28594e455d7a639b256b34b21ace9106ab04bb64

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
M	runtime/vm/compiler.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/compiler.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

srdjan

5 years, 6 months ago (2015-06-23 20:24:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
28594e455d7a639b256b34b21ace9106ab04bb64 (presubmit successful).