Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 1203773002: Disable guessing 'other' cid; this prevents an issue in range analysis. It is not clear if guessing… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: s Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/cha.h" 10 #include "vm/cha.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 "Inlining interval diagnostics"); 44 "Inlining interval diagnostics");
45 DEFINE_FLAG(bool, use_megamorphic_stub, true, "Out of line megamorphic lookup"); 45 DEFINE_FLAG(bool, use_megamorphic_stub, true, "Out of line megamorphic lookup");
46 46
47 DECLARE_FLAG(bool, code_comments); 47 DECLARE_FLAG(bool, code_comments);
48 DECLARE_FLAG(bool, deoptimize_alot); 48 DECLARE_FLAG(bool, deoptimize_alot);
49 DECLARE_FLAG(int, deoptimize_every); 49 DECLARE_FLAG(int, deoptimize_every);
50 DECLARE_FLAG(charp, deoptimize_filter); 50 DECLARE_FLAG(charp, deoptimize_filter);
51 DECLARE_FLAG(bool, disassemble); 51 DECLARE_FLAG(bool, disassemble);
52 DECLARE_FLAG(bool, disassemble_optimized); 52 DECLARE_FLAG(bool, disassemble_optimized);
53 DECLARE_FLAG(bool, emit_edge_counters); 53 DECLARE_FLAG(bool, emit_edge_counters);
54 DECLARE_FLAG(bool, guess_other_cid);
54 DECLARE_FLAG(bool, ic_range_profiling); 55 DECLARE_FLAG(bool, ic_range_profiling);
55 DECLARE_FLAG(bool, intrinsify); 56 DECLARE_FLAG(bool, intrinsify);
56 DECLARE_FLAG(bool, load_deferred_eagerly); 57 DECLARE_FLAG(bool, load_deferred_eagerly);
57 DECLARE_FLAG(int, optimization_counter_threshold); 58 DECLARE_FLAG(int, optimization_counter_threshold);
58 DECLARE_FLAG(bool, propagate_ic_data); 59 DECLARE_FLAG(bool, propagate_ic_data);
59 DECLARE_FLAG(int, regexp_optimization_counter_threshold); 60 DECLARE_FLAG(int, regexp_optimization_counter_threshold);
60 DECLARE_FLAG(int, reoptimization_counter_threshold); 61 DECLARE_FLAG(int, reoptimization_counter_threshold);
61 DECLARE_FLAG(int, stacktrace_every); 62 DECLARE_FLAG(int, stacktrace_every);
62 DECLARE_FLAG(charp, stacktrace_filter); 63 DECLARE_FLAG(charp, stacktrace_filter);
63 DECLARE_FLAG(bool, support_debugger); 64 DECLARE_FLAG(bool, support_debugger);
(...skipping 11 matching lines...) Expand all
75 FLAG_use_field_guards = false; 76 FLAG_use_field_guards = false;
76 FLAG_use_osr = false; 77 FLAG_use_osr = false;
77 FLAG_emit_edge_counters = false; 78 FLAG_emit_edge_counters = false;
78 FLAG_support_debugger = false; 79 FLAG_support_debugger = false;
79 FLAG_ic_range_profiling = false; 80 FLAG_ic_range_profiling = false;
80 FLAG_collect_code = false; 81 FLAG_collect_code = false;
81 FLAG_load_deferred_eagerly = true; 82 FLAG_load_deferred_eagerly = true;
82 FLAG_deoptimize_alot = false; // Used in some tests. 83 FLAG_deoptimize_alot = false; // Used in some tests.
83 FLAG_deoptimize_every = 0; // Used in some tests. 84 FLAG_deoptimize_every = 0; // Used in some tests.
84 FLAG_collect_code = false; 85 FLAG_collect_code = false;
86 FLAG_guess_other_cid = false;
85 Compiler::set_always_optimize(true); 87 Compiler::set_always_optimize(true);
86 Compiler::set_guess_other_cid(false);
87 // TODO(srdjan): Enable CHA deoptimization when eager class finalization is 88 // TODO(srdjan): Enable CHA deoptimization when eager class finalization is
88 // implemented, either with precompilation or as a special pass. 89 // implemented, either with precompilation or as a special pass.
89 FLAG_use_cha_deopt = false; 90 FLAG_use_cha_deopt = false;
90 } 91 }
91 } 92 }
92 93
93 94
94 // --noopt disables optimizer and tunes unoptimized code to run as fast 95 // --noopt disables optimizer and tunes unoptimized code to run as fast
95 // as possible. 96 // as possible.
96 DEFINE_FLAG_HANDLER(NooptModeHandler, 97 DEFINE_FLAG_HANDLER(NooptModeHandler,
(...skipping 1678 matching lines...) Expand 10 before | Expand all | Expand 10 after
1775 1776
1776 1777
1777 void FlowGraphCompiler::FrameStateClear() { 1778 void FlowGraphCompiler::FrameStateClear() {
1778 ASSERT(!is_optimizing()); 1779 ASSERT(!is_optimizing());
1779 frame_state_.TruncateTo(0); 1780 frame_state_.TruncateTo(0);
1780 } 1781 }
1781 #endif 1782 #endif
1782 1783
1783 1784
1784 } // namespace dart 1785 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698