Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: runtime/vm/compiler.cc

Issue 1203773002: Disable guessing 'other' cid; this prevents an issue in range analysis. It is not clear if guessing… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: s Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/compiler.h ('k') | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/block_scheduler.h" 10 #include "vm/block_scheduler.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 DEFINE_FLAG(bool, verify_compiler, false, 64 DEFINE_FLAG(bool, verify_compiler, false,
65 "Enable compiler verification assertions"); 65 "Enable compiler verification assertions");
66 66
67 DECLARE_FLAG(bool, trace_failed_optimization_attempts); 67 DECLARE_FLAG(bool, trace_failed_optimization_attempts);
68 DECLARE_FLAG(bool, trace_inlining_intervals); 68 DECLARE_FLAG(bool, trace_inlining_intervals);
69 DECLARE_FLAG(bool, trace_irregexp); 69 DECLARE_FLAG(bool, trace_irregexp);
70 DECLARE_FLAG(bool, trace_patching); 70 DECLARE_FLAG(bool, trace_patching);
71 71
72 72
73 bool Compiler::always_optimize_ = false; 73 bool Compiler::always_optimize_ = false;
74 bool Compiler::guess_other_cid_ = true;
75 74
76 75
77 // TODO(zerny): Factor out unoptimizing/optimizing pipelines and remove 76 // TODO(zerny): Factor out unoptimizing/optimizing pipelines and remove
78 // separate helpers functions & `optimizing` args. 77 // separate helpers functions & `optimizing` args.
79 class CompilationPipeline : public ZoneAllocated { 78 class CompilationPipeline : public ZoneAllocated {
80 public: 79 public:
81 static CompilationPipeline* New(Zone* zone, const Function& function); 80 static CompilationPipeline* New(Zone* zone, const Function& function);
82 81
83 virtual void ParseFunction(ParsedFunction* parsed_function) = 0; 82 virtual void ParseFunction(ParsedFunction* parsed_function) = 0;
84 virtual FlowGraph* BuildFlowGraph( 83 virtual FlowGraph* BuildFlowGraph(
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1335 const Object& result = 1334 const Object& result =
1336 PassiveObject::Handle(isolate->object_store()->sticky_error()); 1335 PassiveObject::Handle(isolate->object_store()->sticky_error());
1337 isolate->object_store()->clear_sticky_error(); 1336 isolate->object_store()->clear_sticky_error();
1338 return result.raw(); 1337 return result.raw();
1339 } 1338 }
1340 UNREACHABLE(); 1339 UNREACHABLE();
1341 return Object::null(); 1340 return Object::null();
1342 } 1341 }
1343 1342
1344 } // namespace dart 1343 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/compiler.h ('k') | runtime/vm/flow_graph_compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698