Cleaning up event constructors

- Changing event constructors to use named parameters.
- Making more parameters optional.
- Converting remaining init*Event calls to constructors.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17488

[Emily Fortuna, 2013-01-23 01:49:53]

nice change!

https://codereview.chromium.org/12025027/diff/6001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_MutationEvent.darttemplate (right):

https://codereview.chromium.org/12025027/diff/6001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_MutationEvent.darttemplate:8: factory
$CLASSNAME(String type,
can we make this construct the default that's added to each Event class, so we
don't have to create a .darttemplate for each Event class just to pass in
"MutationEvent" or what have you?  (or are there a number of other event classes
where we don't want to use this idiom?)

[blois, 2013-01-23 17:06:49]

https://codereview.chromium.org/12025027/diff/6001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_MutationEvent.darttemplate (right):

https://codereview.chromium.org/12025027/diff/6001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_MutationEvent.darttemplate:8: factory
$CLASSNAME(String type,
On 2013/01/23 01:49:53, Emily Fortuna wrote:
> can we make this construct the default that's added to each Event class, so we
> don't have to create a .darttemplate for each Event class just to pass in
> "MutationEvent" or what have you?  (or are there a number of other event
classes
> where we don't want to use this idiom?)

Only about half of the event classes have init*Event methods and the signature
and defaults for those methods differs for each. I'm not sure we'd gain much by
trying to generate this.

[Emily Fortuna, 2013-01-23 19:02:40]

lgtm.

https://codereview.chromium.org/12025027/diff/6001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_MutationEvent.darttemplate (right):

https://codereview.chromium.org/12025027/diff/6001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_MutationEvent.darttemplate:8: factory
$CLASSNAME(String type,
On 2013/01/23 17:06:49, blois wrote:
> On 2013/01/23 01:49:53, Emily Fortuna wrote:
> > can we make this construct the default that's added to each Event class, so
we
> > don't have to create a .darttemplate for each Event class just to pass in
> > "MutationEvent" or what have you?  (or are there a number of other event
> classes
> > where we don't want to use this idiom?)
> 
> Only about half of the event classes have init*Event methods and the signature
> and defaults for those methods differs for each. I'm not sure we'd gain much
by
> trying to generate this.

Alrighty.

[blois, 2013-01-23 19:29:58]

On 2013/01/23 19:02:40, Emily Fortuna wrote:
> lgtm.
> 
>
https://codereview.chromium.org/12025027/diff/6001/tools/dom/templates/html/i...
> File tools/dom/templates/html/impl/impl_MutationEvent.darttemplate (right):
> 
>
https://codereview.chromium.org/12025027/diff/6001/tools/dom/templates/html/i...
> tools/dom/templates/html/impl/impl_MutationEvent.darttemplate:8: factory
> $CLASSNAME(String type,
> On 2013/01/23 17:06:49, blois wrote:
> > On 2013/01/23 01:49:53, Emily Fortuna wrote:
> > > can we make this construct the default that's added to each Event class,
so
> we
> > > don't have to create a .darttemplate for each Event class just to pass in
> > > "MutationEvent" or what have you?  (or are there a number of other event
> > classes
> > > where we don't want to use this idiom?)
> > 
> > Only about half of the event classes have init*Event methods and the
signature
> > and defaults for those methods differs for each. I'm not sure we'd gain much
> by
> > trying to generate this.
> 
> Alrighty.

Realized that I had missed a couple of events-
Added TouchEvent, TextEvent, StorageEvent, CompositionEvent.

ptal.

[Emily Fortuna, 2013-01-23 19:33:44]

lgtm with some suggestions

https://codereview.chromium.org/12025027/diff/10001/tools/dom/templates/html/...
File tools/dom/templates/html/impl/impl_TouchEvent.darttemplate (right):

https://codereview.chromium.org/12025027/diff/10001/tools/dom/templates/html/...
tools/dom/templates/html/impl/impl_TouchEvent.darttemplate:12: {Window view, int
screenX: 0, int screenY: 0, int clientX: 0,
tests of at least constructors for these new classes you added? Also, have we
crossed the threshold on which more classes use this format and it could benefit
from being auto-generated instead of having templates for each event class? :-)