tools/dom/templates/html/impl/impl_MutationEvent.darttemplate - Issue 12025027: Cleaning up event constructors

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/dom/templates/html/impl/impl_MutationEvent.darttemplate

Issue 12025027: Cleaning up event constructors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 part of html;

	6

	7 $(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {

	8 factory $CLASSNAME(String type,
	Emily Fortuna 2013/01/23 01:49:53 can we make this construct the default that's adde can we make this construct the default that's added to each Event class, so we don't have to create a .darttemplate for each Event class just to pass in "MutationEvent" or what have you? (or are there a number of other event classes where we don't want to use this idiom?) blois 2013/01/23 17:06:49 Only about half of the event classes have initEve Show quoted text On 2013/01/23 01:49:53, Emily Fortuna wrote: > can we make this construct the default that's added to each Event class, so we > don't have to create a .darttemplate for each Event class just to pass in > "MutationEvent" or what have you? (or are there a number of other event classes > where we don't want to use this idiom?) Only about half of the event classes have initEvent methods and the signature and defaults for those methods differs for each. I'm not sure we'd gain much by trying to generate this. Emily Fortuna 2013/01/23 19:02:40 Alrighty. Show quoted text On 2013/01/23 17:06:49, blois wrote: > On 2013/01/23 01:49:53, Emily Fortuna wrote: > > can we make this construct the default that's added to each Event class, so we > > don't have to create a .darttemplate for each Event class just to pass in > > "MutationEvent" or what have you? (or are there a number of other event > classes > > where we don't want to use this idiom?) > > Only about half of the event classes have init*Event methods and the signature > and defaults for those methods differs for each. I'm not sure we'd gain much by > trying to generate this. Alrighty.
	9 {bool canBubble: false, bool cancelable: false, Node relatedNode,

	10 String prevValue, String newValue, String attrName, int attrChange: 0}) {

	11

	12 var event = document.$dom_createEvent('MutationEvent');

	13 event.$dom_initMutationEvent(type, canBubble, cancelable, relatedNode,

	14 prevValue, newValue, attrName, attrChange);

	15 return event;

	16 }

	17 $!MEMBERS

	18 }

	19

	20

	21

OLD	NEW