Small bugfix in test_suite.dart

Small bugfix in test_suite.dart

Committed: https://code.google.com/p/dart/source/detail?r=17702

[kustermann, 2013-01-18 14:15:00]

I'm not sure if this is the right approach, what do you think?

[ricow1, 2013-01-23 14:40:32]

lgtm

https://codereview.chromium.org/11929022/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11929022/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:976: if (serverList.length >= 2) {
why not just check if we passed the list flag?

[kustermann, 2013-01-23 17:25:08]

PTAL.

I've changed it now a bit. If we list the tests we probably still want to get
complete URLs. So in case of 'list'ing I put the dummy PORT/CROSS_ORIGIN_PORT
strings there instead of the real ports.

[ricow1, 2013-01-24 14:06:14]

LGTM

https://codereview.chromium.org/11929022/diff/5001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11929022/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:979: serverPort = serverList[0].port;
this is probably slightly messing up types, what about:
serverPort = serverList[0].port.toString();

[ahe, 2013-01-25 12:40:23]

DBC

https://codereview.chromium.org/11929022/diff/5001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11929022/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:976: var serverPort = "PORT";
It is kinda hard to understand how this works. Could you explain how this
prevents servers from starting?

[kustermann, 2013-01-28 11:20:54]

https://codereview.chromium.org/11929022/diff/5001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11929022/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:976: var serverPort = "PORT";
On 2013/01/25 12:40:23, ahe wrote:
> It is kinda hard to understand how this works. Could you explain how this
> prevents servers from starting?

This doesn't prevent servers from starting. In tools/test.dart we check if
'--list' was passed. If so, we don't start http servers.

The issue is, that currently if we try to run
"tools/test.py .... --list html"
for example, test.dart crashes, because it tries to access
serverList[0]/serverList[1], but serverList is empty (since no http servers were
started).

The CL now replaces the port numbers with the symbolic names
"PORT/CROSS_ORIGIN_PORT" in case no http servers were started.

https://codereview.chromium.org/11929022/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:979: serverPort = serverList[0].port;
On 2013/01/24 14:06:14, ricow1 wrote:
> this is probably slightly messing up types, what about:
> serverPort = serverList[0].port.toString();

Done.