Small bugfix in test_suite.dart

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 953 matching lines @@
 
         List<String> args = <String>[];
         var basePath = TestUtils.dartDir().toString();
         if (!htmlPath.startsWith('/') && !htmlPath.startsWith('http')) {
           htmlPath = '/$htmlPath';
         }
         htmlPath = htmlPath.startsWith(basePath) ?
             htmlPath.substring(basePath.length) : htmlPath;
         String fullHtmlPath = htmlPath;
         if (!htmlPath.startsWith('http')) {
-          fullHtmlPath = 'http://127.0.0.1:${serverList[0].port}$htmlPath?'
-              'crossOriginPort=${serverList[1].port}';
+          // Note: If we run test.py with the "--list" option, no http servers
+          // will be started.
+          var serverPort = "PORT";

[ahe, 2013/01/25 12:40:23]

It is kinda hard to understand how this works. Could you explain how this
prevents servers from starting?

[kustermann, 2013/01/28 11:20:54]

This doesn't prevent servers from starting. In tools/test.dart we check if
'--list' was passed. If so, we don't start http servers.

The issue is, that currently if we try to run
"tools/test.py .... --list html"
for example, test.dart crashes, because it tries to access
serverList[0]/serverList[1], but serverList is empty (since no http servers were
started).

The CL now replaces the port numbers with the symbolic names
"PORT/CROSS_ORIGIN_PORT" in case no http servers were started.

+          var crossOriginPort = "CROSS_ORIGIN_PORT";
+          if (!configuration['list']) {
+            serverPort = serverList[0].port;

[ricow1, 2013/01/24 14:06:14]

this is probably slightly messing up types, what about:
serverPort = serverList[0].port.toString();

[kustermann, 2013/01/28 11:20:54]

Done.

+            crossOriginPort = serverList[1].port;
+          }
+          fullHtmlPath = 'http://127.0.0.1:$serverPort$htmlPath?'
+              'crossOriginPort=$crossOriginPort';
         }
         if (info.optionsFromFile['isMultiHtmlTest']
             && subtestNames.length > 0) {
           fullHtmlPath = '${fullHtmlPath}#${subtestNames[subtestIndex]}';
         }
 
         if (TestUtils.usesWebDriver(runtime)) {
           args = [
               dartDir.append('tools/testing/run_selenium.py').toNativePath(),
               '--browser=$runtime',
@@ skipping 911 matching lines @@
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
  * $compileErrorSkip tests are skipped on browsers due to compile-time error
 """;
     print(report);
    }
 }