Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 11929022: Small bugfix in test_suite.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 953 matching lines...) Expand 10 before | Expand all | Expand 10 after
964 964
965 List<String> args = <String>[]; 965 List<String> args = <String>[];
966 var basePath = TestUtils.dartDir().toString(); 966 var basePath = TestUtils.dartDir().toString();
967 if (!htmlPath.startsWith('/') && !htmlPath.startsWith('http')) { 967 if (!htmlPath.startsWith('/') && !htmlPath.startsWith('http')) {
968 htmlPath = '/$htmlPath'; 968 htmlPath = '/$htmlPath';
969 } 969 }
970 htmlPath = htmlPath.startsWith(basePath) ? 970 htmlPath = htmlPath.startsWith(basePath) ?
971 htmlPath.substring(basePath.length) : htmlPath; 971 htmlPath.substring(basePath.length) : htmlPath;
972 String fullHtmlPath = htmlPath; 972 String fullHtmlPath = htmlPath;
973 if (!htmlPath.startsWith('http')) { 973 if (!htmlPath.startsWith('http')) {
974 fullHtmlPath = 'http://127.0.0.1:${serverList[0].port}$htmlPath?' 974 // Note: If we run test.py with the "--list" option, no http servers
975 'crossOriginPort=${serverList[1].port}'; 975 // will be started. Therefore we need the following condition.
976 if (serverList.length >= 2) {
ricow1 2013/01/23 14:40:32 why not just check if we passed the list flag?
977 fullHtmlPath = 'http://127.0.0.1:${serverList[0].port}$htmlPath?'
978 'crossOriginPort=${serverList[1].port}';
979 }
976 } 980 }
977 if (info.optionsFromFile['isMultiHtmlTest'] 981 if (info.optionsFromFile['isMultiHtmlTest']
978 && subtestNames.length > 0) { 982 && subtestNames.length > 0) {
979 fullHtmlPath = '${fullHtmlPath}#${subtestNames[subtestIndex]}'; 983 fullHtmlPath = '${fullHtmlPath}#${subtestNames[subtestIndex]}';
980 } 984 }
981 985
982 if (TestUtils.usesWebDriver(runtime)) { 986 if (TestUtils.usesWebDriver(runtime)) {
983 args = [ 987 args = [
984 dartDir.append('tools/testing/run_selenium.py').toNativePath(), 988 dartDir.append('tools/testing/run_selenium.py').toNativePath(),
985 '--browser=$runtime', 989 '--browser=$runtime',
(...skipping 907 matching lines...) Expand 10 before | Expand all | Expand 10 after
1893 * $pass tests are expected to pass 1897 * $pass tests are expected to pass
1894 * $failOk tests are expected to fail that we won't fix 1898 * $failOk tests are expected to fail that we won't fix
1895 * $fail tests are expected to fail that we should fix 1899 * $fail tests are expected to fail that we should fix
1896 * $crash tests are expected to crash that we should fix 1900 * $crash tests are expected to crash that we should fix
1897 * $timeout tests are allowed to timeout 1901 * $timeout tests are allowed to timeout
1898 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1902 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1899 """; 1903 """;
1900 print(report); 1904 print(report);
1901 } 1905 }
1902 } 1906 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698