Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1189573004: Use object pool for runtime calls. (Closed)

Created:
5 years, 6 months ago by Florian Schneider
Modified:
5 years, 6 months ago
Reviewers:
rmacnak, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use object pool for runtime calls. Also, set up a stub frame with object pool loaded in all stubs on those platforms. This is a preparation step to making code relocatable. ia32 is not affected because there is no object pool. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/957af25419e79862406fb6815725b5b787cf22cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -116 lines) Patch
M runtime/vm/assembler_arm.h View 3 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm.cc View 3 chunks +20 lines, -7 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/assembler_mips.h View 3 chunks +13 lines, -4 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64.h View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M runtime/vm/runtime_entry_arm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/runtime_entry_arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry_mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/runtime_entry_x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code.h View 2 chunks +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_arm.cc View 8 chunks +8 lines, -20 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 8 chunks +8 lines, -32 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/stub_code_x64_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 6 months ago (2015-06-16 14:07:16 UTC) #2
srdjan
lgtm
5 years, 6 months ago (2015-06-16 14:26:01 UTC) #3
Florian Schneider
5 years, 6 months ago (2015-06-17 08:37:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
957af25419e79862406fb6815725b5b787cf22cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698