runtime/vm/runtime_entry_x64.cc - Issue 1189573004: Use object pool for runtime calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/runtime_entry_x64.cc

Issue 1189573004: Use object pool for runtime calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/runtime_entry_x64.cc

diff --git a/runtime/vm/runtime_entry_x64.cc b/runtime/vm/runtime_entry_x64.cc

index 7d0779580bf6a49cd8cdbe658fb6462edd5205f4..705eacd9473a4bea66763c644c3abd4c831d50b1 100644

--- a/runtime/vm/runtime_entry_x64.cc

+++ b/runtime/vm/runtime_entry_x64.cc

@@ -28,7 +28,8 @@ void RuntimeEntry::Call(Assembler* assembler, intptr_t argument_count) const {

} else {

// Argument count is not checked here, but in the runtime entry for a more

// informative error message.

- __ movq(RBX, Immediate(GetEntryPoint()));

+ ExternalLabel label(GetEntryPoint());

+ __ LoadExternalLabel(RBX, &label, kNotPatchable, PP);

__ movq(R10, Immediate(argument_count));

__ Call(&Isolate::Current()->stub_code()->CallToRuntimeLabel(), PP);

}

« no previous file with comments | « runtime/vm/runtime_entry_mips.cc ('k') | runtime/vm/stub_code.h » ('j') | no next file with comments »