Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Unified Diff: runtime/vm/assembler_mips.h

Issue 1189573004: Use object pool for runtime calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips.h
diff --git a/runtime/vm/assembler_mips.h b/runtime/vm/assembler_mips.h
index 9f8a4db61aa8339ead955eb7b8067aa4940922ea..79e653967bed1da9d2c0a54de115494acfb25c42 100644
--- a/runtime/vm/assembler_mips.h
+++ b/runtime/vm/assembler_mips.h
@@ -287,7 +287,7 @@ class Assembler : public ValueObject {
// Set up a stub frame so that the stack traversal code can easily identify
// a stub frame.
- void EnterStubFrame(bool load_pp = false);
+ void EnterStubFrame();
void LeaveStubFrame();
// A separate macro for when a Ret immediately follows, so that we can use
// the branch delay slot.
@@ -926,13 +926,19 @@ class Assembler : public ValueObject {
jalr(T9);
}
- void BranchLinkPatchable(const ExternalLabel* label) {
+ void BranchLink(const ExternalLabel* label, Patchability patchable) {
ASSERT(!in_delay_slot_);
const int32_t offset = ObjectPool::element_offset(
- object_pool_wrapper_.FindExternalLabel(label, kPatchable));
+ object_pool_wrapper_.FindExternalLabel(label, patchable));
LoadWordFromPoolOffset(T9, offset - kHeapObjectTag);
jalr(T9);
- delay_slot_available_ = false; // CodePatcher expects a nop.
+ if (patchable == kPatchable) {
+ delay_slot_available_ = false; // CodePatcher expects a nop.
+ }
+ }
+
+ void BranchLinkPatchable(const ExternalLabel* label) {
+ BranchLink(label, kPatchable);
}
void Drop(intptr_t stack_elements) {
@@ -1533,6 +1539,9 @@ class Assembler : public ValueObject {
void LoadWordFromPoolOffset(Register rd, int32_t offset);
void LoadObject(Register rd, const Object& object);
+ void LoadExternalLabel(Register rd,
+ const ExternalLabel* label,
+ Patchability patchable);
void PushObject(const Object& object);
void LoadIsolate(Register result);
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698