Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11881021: Report external without patch as an error. (Closed)

Created:
7 years, 11 months ago by Johnni Winther
Modified:
7 years, 10 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report external without patch as an error. Committed: https://code.google.com/p/dart/source/detail?r=17707

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment + added test. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -47 lines) Patch
M sdk/lib/_internal/compiler/implementation/diagnostic_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 17 chunks +108 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
7 years, 11 months ago (2013-01-14 11:45:33 UTC) #1
ahe
I'd like to have a test. https://codereview.chromium.org/11881021/diff/1/sdk/lib/_internal/compiler/implementation/scanner/listener.dart File sdk/lib/_internal/compiler/implementation/scanner/listener.dart (right): https://codereview.chromium.org/11881021/diff/1/sdk/lib/_internal/compiler/implementation/scanner/listener.dart#newcode1862 sdk/lib/_internal/compiler/implementation/scanner/listener.dart:1862: MessageKind.EXTERNAL_WITHOUT_PATCH.error(), How about: ...
7 years, 11 months ago (2013-01-21 11:15:40 UTC) #2
Johnni Winther
PTAL https://codereview.chromium.org/11881021/diff/1/sdk/lib/_internal/compiler/implementation/scanner/listener.dart File sdk/lib/_internal/compiler/implementation/scanner/listener.dart (right): https://codereview.chromium.org/11881021/diff/1/sdk/lib/_internal/compiler/implementation/scanner/listener.dart#newcode1862 sdk/lib/_internal/compiler/implementation/scanner/listener.dart:1862: MessageKind.EXTERNAL_WITHOUT_PATCH.error(), On 2013/01/21 11:15:40, ahe wrote: > How ...
7 years, 11 months ago (2013-01-22 15:22:49 UTC) #3
ahe
7 years, 11 months ago (2013-01-23 11:10:15 UTC) #4 
LGTM!

Powered by Google App Engine
This is Rietveld 408576698