Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 11881021: Report external without patch as an error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 class MessageKind { 7 class MessageKind {
8 final String template; 8 final String template;
9 const MessageKind(this.template); 9 const MessageKind(this.template);
10 10
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 "count on origin method '#{1}' (#{2})."); 362 "count on origin method '#{1}' (#{2}).");
363 363
364 static const PATCH_OPTIONAL_PARAMETER_NAMED_MISMATCH = const MessageKind( 364 static const PATCH_OPTIONAL_PARAMETER_NAMED_MISMATCH = const MessageKind(
365 "Optional parameters of origin and patch method '#{1}' must " 365 "Optional parameters of origin and patch method '#{1}' must "
366 "both be either named or positional."); 366 "both be either named or positional.");
367 367
368 static const PATCH_PARAMETER_MISMATCH = const MessageKind( 368 static const PATCH_PARAMETER_MISMATCH = const MessageKind(
369 "Patch method parameter '#{3}' doesn't match '#{2}' on origin method " 369 "Patch method parameter '#{3}' doesn't match '#{2}' on origin method "
370 "#{1}."); 370 "#{1}.");
371 371
372 static const EXTERNAL_WITHOUT_IMPLEMENTATION = const MessageKind(
373 "External method without an implementation.");
374
372 static const TOP_LEVEL_VARIABLE_DECLARED_STATIC = const MessageKind( 375 static const TOP_LEVEL_VARIABLE_DECLARED_STATIC = const MessageKind(
373 "Top-level variable cannot be declared static."); 376 "Top-level variable cannot be declared static.");
374 377
375 static const WRONG_NUMBER_OF_ARGUMENTS_FOR_ASSERT = const MessageKind( 378 static const WRONG_NUMBER_OF_ARGUMENTS_FOR_ASSERT = const MessageKind(
376 "Wrong number of arguments to assert. Should be 1, but given #{1}."); 379 "Wrong number of arguments to assert. Should be 1, but given #{1}.");
377 380
378 static const ASSERT_IS_GIVEN_NAMED_ARGUMENTS = const MessageKind( 381 static const ASSERT_IS_GIVEN_NAMED_ARGUMENTS = const MessageKind(
379 "assert takes no named arguments, but given #{1}."); 382 "assert takes no named arguments, but given #{1}.");
380 383
381 static const MALFORMED_TYPE_REFERENCE = const MessageKind( 384 static const MALFORMED_TYPE_REFERENCE = const MessageKind(
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 481
479 class CompileTimeConstantError extends Diagnostic { 482 class CompileTimeConstantError extends Diagnostic {
480 CompileTimeConstantError(MessageKind kind, List arguments) 483 CompileTimeConstantError(MessageKind kind, List arguments)
481 : super(kind, arguments); 484 : super(kind, arguments);
482 } 485 }
483 486
484 class CompilationError extends Diagnostic { 487 class CompilationError extends Diagnostic {
485 CompilationError(MessageKind kind, List arguments) 488 CompilationError(MessageKind kind, List arguments)
486 : super(kind, arguments); 489 : super(kind, arguments);
487 } 490 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/scanner/listener.dart ('k') | tests/compiler/dart2js/patch_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698