Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: sdk/lib/_internal/compiler/implementation/scanner/listener.dart

Issue 11881021: Report external without patch as an error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/scanner/listener.dart
diff --git a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
index 8f1b67529b608fda54b9c3e51ffc616e7e6b71ca..216c9286da3aca43de771275fbb19c86a704516b 100644
--- a/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
+++ b/sdk/lib/_internal/compiler/implementation/scanner/listener.dart
@@ -1909,8 +1909,10 @@ class PartialFunctionElement extends FunctionElementX {
if (cachedNode != null) return cachedNode;
if (patch == null) {
if (modifiers.isExternal()) {
- listener.cancel("External method without an implementation",
- element: this);
+ listener.reportMessage(
+ listener.spanFromSpannable(this),
+ MessageKind.EXTERNAL_WITHOUT_IMPLEMENTATION.error(),
+ api_s.Diagnostic.ERROR);
}
}
parseFunction(Parser p) {

Powered by Google App Engine
This is Rietveld 408576698