Issue 11859037: Remove collection-dev from the html and js-helper library.

Issue 11859037: Remove collection-dev from the html and js-helper library. (Closed)

Created:
7 years, 11 months ago by floitsch

Modified:
7 years, 11 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove collection-dev from the html and js-helper library. Committed: https://code.google.com/p/dart/source/detail?r=17358

Patch Set 2 : Also avoid collection-dev in js-helper. #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -18 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/lib/constant_map.dart	View	1	1 chunk	+2 lines, -1 line	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/11859037/diff/2001/sdk/lib/_internal/compiler/implementation/lib/constant_map.dart File sdk/lib/_internal/compiler/implementation/lib/constant_map.dart (right): https://codereview.chromium.org/11859037/diff/2001/sdk/lib/_internal/compiler/implementation/lib/constant_map.dart#newcode39 sdk/lib/_internal/compiler/implementation/lib/constant_map.dart:39: return keys.mappedBy((String key) => this[key]); Just do: return ...

7 years, 11 months ago (2013-01-21 09:02:03 UTC) #2

floitsch

7 years, 11 months ago (2013-01-21 14:16:10 UTC) #3

https://codereview.chromium.org/11859037/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/lib/constant_map.dart (right):

https://codereview.chromium.org/11859037/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/lib/constant_map.dart:39: return
keys.mappedBy((String key) => this[key]);
On 2013/01/21 09:02:03, Lasse Reichstein Nielsen wrote:
> Just do:
>   return _keys.mappedBy((String key) => this[key]);
> Should avoid the second wrapping.
> You can even consider doing
>   return _keys.mappedBy((String key) => jsPropertyAccess(_jsObject, key));
> to save the containsKey check which is always true.

No. The return type of 'values' should be an Iterable and not a List. This is,
why keys is wrapped, too.

Expand Messages | Collapse Messages