Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 11859037: Remove collection-dev from the html and js-helper library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Also avoid collection-dev in js-helper. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 5420f09f43681b1fc1d77397208af0faa65eb114..5314723c3dd07ccdd6cd2f3224e8f1ea0d4d9ef2 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -2,7 +2,6 @@ library html;
import 'dart:async';
import 'dart:collection';
-import 'dart:collection-dev';
import 'dart:html_common';
import 'dart:indexed_db';
import 'dart:isolate';
@@ -20530,14 +20529,16 @@ class SelectElement extends _Element_Merged {
// does not operate as a List.
List<OptionElement> get options {
var options = this.children.where((e) => e is OptionElement).toList();
- return new ListView(options, 0, options.length);
+ // TODO(floitsch): find better way to create a read-only list view.
+ return options.take(options.length);
}
List<OptionElement> get selectedOptions {
// IE does not change the selected flag for single-selection items.
if (this.multiple) {
var options = this.options.where((o) => o.selected).toList();
- return new ListView(options, 0, options.length);
+ // TODO(floitsch): find better way to create a read-only list view.
+ return options.take(options.length);
} else {
return [this.options[this.selectedIndex]];
}

Powered by Google App Engine
This is Rietveld 408576698