Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1531)

Unified Diff: tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate

Issue 11859037: Remove collection-dev from the html and js-helper library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Also avoid collection-dev in js-helper. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate b/tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate
index de3a920f562787388980586701c3216cb90e718f..3f2cc578b625e7c8919f27916a961cc63b733a01 100644
--- a/tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate
+++ b/tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate
@@ -11,14 +11,16 @@ $!MEMBERS
// does not operate as a List.
List<OptionElement> get options {
var options = this.children.where((e) => e is OptionElement).toList();
- return new ListView(options, 0, options.length);
+ // TODO(floitsch): find better way to create a read-only list view.
+ return options.take(options.length);
}
List<OptionElement> get selectedOptions {
// IE does not change the selected flag for single-selection items.
if (this.multiple) {
var options = this.options.where((o) => o.selected).toList();
- return new ListView(options, 0, options.length);
+ // TODO(floitsch): find better way to create a read-only list view.
+ return options.take(options.length);
} else {
return [this.options[this.selectedIndex]];
}

Powered by Google App Engine
This is Rietveld 408576698