Issue 11827017: Update remaining usages of Completer.completeException.

Issue 11827017: Update remaining usages of Completer.completeException. (Closed)

Created:
7 years, 11 months ago by Mads Ager (google)

Modified:
7 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update remaining usages of Completer.completeException. R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=16840

Patch Set 2 : Address comments. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+154 lines, -123 lines)			Patch
M	pkg/webdriver/lib/webdriver.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	samples/dartcombat/state.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/file_impl.dart	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/lib/async/future_test.dart	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	tests/standalone/io/file_invalid_arguments_test.dart	View	1	1 chunk	+129 lines, -91 lines	0 comments	Download
M	tools/dom/src/Measurement.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/html_json_doc/lib/html_to_json.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/release/version.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	utils/archive/entry.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/archive/input_stream.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_invalid_arguments_test.dart File tests/standalone/io/file_invalid_arguments_test.dart (right): https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_invalid_arguments_test.dart#newcode23 tests/standalone/io/file_invalid_arguments_test.dart:23: Expect.fail('read list invalid arguments'); replace string with "Exception ...

7 years, 11 months ago (2013-01-09 09:12:59 UTC) #2

Mads Ager (google)

7 years, 11 months ago (2013-01-09 09:29:14 UTC) #3

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
File tests/standalone/io/file_invalid_arguments_test.dart (right):

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:23: Expect.fail('read list
invalid arguments');
On 2013/01/09 09:12:59, floitsch wrote:
> replace string with "Exception expected".
> The e.error.toString().contains below checks for "Invalid arguments" with a
> capital "I", and therefore would never match, but just to make it even more
> obvious that we don't want to catch this error below.

Done.

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:26: Expect.isTrue(e.error
is FileIOException);
On 2013/01/09 09:12:59, floitsch wrote:
> Alternatively you could use "test: (error) => error is FileIOException" (as
> named argument to catchError).

I find this more readable since I want to check more and don't want to combine
it all to one boolean.

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:55: Expect.equals(1,
errors);
On 2013/01/09 09:12:59, floitsch wrote:
> add a receive-port to make sure the test is run.

Done.

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:73: Expect.fail('write byte
invalid argument');
On 2013/01/09 09:12:59, floitsch wrote:
> ditto (change exception string).

Done.

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:77: file.close();
On 2013/01/09 09:12:59, floitsch wrote:
> ditto (receive-port).

Done.

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:94: Expect.fail('write list
invalid argument');
On 2013/01/09 09:12:59, floitsch wrote:
> ditto (change exception string).

Done.

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:98: file.close();
On 2013/01/09 09:12:59, floitsch wrote:
> ditto (receive-port).

Done.

https://codereview.chromium.org/11827017/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:125: Expect.equals(1,
errors);
Added port to this test as well and closed it here.

Expand Messages | Collapse Messages