Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: tools/release/version.dart

Issue 11827017: Update remaining usages of Completer.completeException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/html_json_doc/lib/html_to_json.dart ('k') | utils/archive/entry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/release/version.dart
diff --git a/tools/release/version.dart b/tools/release/version.dart
index ecc96253f0690f3ca5c33f014086b5fbd8a8de4e..2f3ae04ed4a1efa3501ef62376e6602c9b5d2c4e 100644
--- a/tools/release/version.dart
+++ b/tools/release/version.dart
@@ -49,20 +49,20 @@ class Version {
Completer c = new Completer();
f.exists().then((existed) {
if (!existed) {
- c.completeException("No VERSION file");
+ c.completeError("No VERSION file");
return;
}
StringInputStream input = new StringInputStream(f.openInputStream());
input.onLine = () {
var line = input.readLine().trim();
if (line == null) {
- c.completeException(
+ c.completeError(
"VERSION input file seems to be in the wrong format");
return;
}
var values = line.split(" ");
if (values.length != 2) {
- c.completeException(
+ c.completeError(
"VERSION input file seems to be in the wrong format");
return;
}
@@ -70,7 +70,7 @@ class Version {
try {
number = int.parse(values[1]);
} catch (e) {
- c.completeException("Can't parse version numbers, not an int");
+ c.completeError("Can't parse version numbers, not an int");
return;
}
switch (values[0]) {
@@ -87,8 +87,8 @@ class Version {
PATCH = number;
break;
default:
- c.completeException("Wrong format in VERSION file, line does not "
- "contain one of {MAJOR, MINOR, BUILD, PATCH}");
+ c.completeError("Wrong format in VERSION file, line does not "
+ "contain one of {MAJOR, MINOR, BUILD, PATCH}");
return;
}
};
« no previous file with comments | « tools/html_json_doc/lib/html_to_json.dart ('k') | utils/archive/entry.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698