sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart - Issue 11827017: Update remaining usages of Completer.completeException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

Issue 11827017: Update remaining usages of Completer.completeException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

index 08a2cbbe6c14c26fddb13e10f5228b167355dd35..2177ca9d23aab1ca58f49ba42ec5d5f6dab9bd27 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart

@@ -624,7 +624,7 @@ class _BaseSendPort implements SendPort {

port.receive((value, ignoreReplyTo) {

port.close();

if (value is Exception) {

- completer.completeException(value);

+ completer.completeError(value);

} else {

completer.complete(value);

}

« no previous file with comments | « samples/dartcombat/state.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart » ('j') | no next file with comments »