Use ArgumentError.value in more places in js_lib.

Use ArgumentError.value in more places in js_lib.

Main effect is that more numeric operations will indicate 'null' is the problem argument, e.g.

    Illegal Arguments(s)
-->
    Illegal Argument: null


BUG=
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/773d7b00fbf69ba3cd1eff4058196a0c0e03fc9e

[sra1, 2015-06-19 04:13:42]

sra@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2015-06-19 12:22:06]

lgtm

https://codereview.chromium.org/1181003005/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/core_patch.dart (right):

https://codereview.chromium.org/1181003005/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/core_patch.dart:184: isUtc is bool ? isUtc :
throw new ArgumentError.value(isUtc),
Use .value(isUtc, "isUtc").

https://codereview.chromium.org/1181003005/diff/1/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/1181003005/diff/1/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1431: @NoInline()
So this function exists only to NOT be inlined? :)

[sra1, 2015-06-19 17:58:00]

https://chromiumcodereview.appspot.com/1181003005/diff/1/sdk/lib/_internal/co...
File sdk/lib/_internal/compiler/js_lib/core_patch.dart (right):

https://chromiumcodereview.appspot.com/1181003005/diff/1/sdk/lib/_internal/co...
sdk/lib/_internal/compiler/js_lib/core_patch.dart:184: isUtc is bool ? isUtc :
throw new ArgumentError.value(isUtc),
On 2015/06/19 12:22:06, Lasse Reichstein Nielsen wrote:
> Use .value(isUtc, "isUtc").

Done.

https://chromiumcodereview.appspot.com/1181003005/diff/1/sdk/lib/_internal/co...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/1181003005/diff/1/sdk/lib/_internal/co...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:1431: @NoInline()
On 2015/06/19 12:22:06, Lasse Reichstein Nielsen wrote:
> So this function exists only to NOT be inlined? :)

Yes.  I'd like dart2js to be able to do this automatically but it is a long way
off.

[sra1, 2015-06-19 18:02:38]

Committed patchset #2 (id:20001) manually as
773d7b00fbf69ba3cd1eff4058196a0c0e03fc9e (presubmit successful).