Use ArgumentError.value in more places in js_lib.

sdk/lib/_internal/compiler/js_lib/js_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library _js_helper;
 
 import 'dart:_async_await_error_codes' as async_error_codes;
 
 import 'dart:_js_embedded_names' show
     DEFERRED_LIBRARY_URIS,
@@ skipping 192 matching lines @@
       return JS('String', r'"" + (#)', value);
     }
   } else if (true == value) {
     return 'true';
   } else if (false == value) {
     return 'false';
   } else if (value == null) {
     return 'null';
   }
   var res = value.toString();
-  if (res is !String) throw _argumentError(value);
+  if (res is !String) throw argumentErrorValue(value);
   return res;
 }
 
 createInvocationMirror(String name, internalName, kind, arguments,
                        argumentNames) {
   return new JSInvocationMirror(name,
                                 internalName,
                                 kind,
                                 arguments,
                                 argumentNames);
@@ skipping 650 matching lines @@
       result = JS('String',
           r'# + String.fromCharCode.apply(null, #.slice(#, #))',
           result, array, i, chunkEnd);
     }
     return result;
   }
 
   static String stringFromCodePoints(codePoints) {
     List<int> a = <int>[];
     for (var i in codePoints) {
-      if (i is !int) throw _argumentError(i);
+      if (i is !int) throw argumentErrorValue(i);
       if (i <= 0xffff) {
         a.add(i);
       } else if (i <= 0x10ffff) {
         a.add(0xd800 + ((((i - 0x10000) >> 10) & 0x3ff)));
         a.add(0xdc00 + (i & 0x3ff));
       } else {
-        throw _argumentError(i);
+        throw argumentErrorValue(i);
       }
     }
     return _fromCharCodeApply(a);
   }
 
   static String stringFromCharCodes(charCodes) {
     for (var i in charCodes) {
-      if (i is !int) throw _argumentError(i);
-      if (i < 0) throw _argumentError(i);
+      if (i is !int) throw argumentErrorValue(i);
+      if (i < 0) throw argumentErrorValue(i);
       if (i > 0xffff) return stringFromCodePoints(charCodes);
     }
     return _fromCharCodeApply(charCodes);
   }
 
   // [start] and [end] are validated.
   static String stringFromNativeUint8List(
       NativeUint8List charCodes, int start, int end) {
     const kMaxApply = 500;
     if (end <= kMaxApply && start == 0 && end == charCodes.length) {
@@ skipping 168 matching lines @@
 
   static getWeekday(receiver) {
     int weekday = (receiver.isUtc)
       ? JS('int', r'#.getUTCDay() + 0', lazyAsJsDate(receiver))
       : JS('int', r'#.getDay() + 0', lazyAsJsDate(receiver));
     // Adjust by one because JS weeks start on Sunday.
     return (weekday + 6) % 7 + 1;
   }
 
   static valueFromDateString(str) {
-    if (str is !String) throw _argumentError(str);
+    if (str is !String) throw argumentErrorValue(str);
     var value = JS('num', r'Date.parse(#)', str);
-    if (value.isNaN) throw _argumentError(str);
+    if (value.isNaN) throw argumentErrorValue(str);
     return value;
   }
 
   static getProperty(object, key) {
     if (object == null || object is bool || object is num || object is String) {
-      throw _argumentError(object);
+      throw argumentErrorValue(object);
     }
     return JS('var', '#[#]', object, key);
   }
 
   static void setProperty(object, key, value) {
     if (object == null || object is bool || object is num || object is String) {
-      throw _argumentError(object);
+      throw argumentErrorValue(object);
     }
     JS('void', '#[#] = #', object, key, value);
   }
 
   static functionNoSuchMethod(function,
                               List positionalArguments,
                               Map<String, dynamic> namedArguments) {
     int argumentCount = 0;
     List arguments = [];
     List namedArgumentList = [];
@@ skipping 268 matching lines @@
   }
 }
 
 /**
  * Called by generated code to throw an illegal-argument exception,
  * for example, if a non-integer index is given to an optimized
  * indexed access.
  */
 @NoInline()
 iae(argument) {
-  throw _argumentError(argument);
+  throw argumentErrorValue(argument);
 }
 
 /**
  * Called by generated code to throw an index-out-of-range exception, for
  * example, if a bounds check fails in an optimized indexed access.  This may
  * also be called when the index is not an integer, in which case it throws an
  * illegal-argument exception instead, like [iae], or when the receiver is null.
  */
 @NoInline()
 ioore(receiver, index) {
@@ skipping 18 matching lines @@
   return new RangeError.value(index, 'index');
 }
 
 
 stringLastIndexOfUnchecked(receiver, element, start)
   => JS('int', r'#.lastIndexOf(#, #)', receiver, element, start);
 
 
 /// 'factory' for constructing ArgumentError.value to keep the call sites small.
 @NoInline()
-ArgumentError _argumentError(object) {
+ArgumentError argumentErrorValue(object) {
   return new ArgumentError.value(object);
 }
 
 checkNull(object) {
-  if (object == null) throw _argumentError(object);
+  if (object == null) throw argumentErrorValue(object);
   return object;
 }
 
 checkNum(value) {
-  if (value is !num) throw _argumentError(value);
+  if (value is !num) throw argumentErrorValue(value);
   return value;
 }
 
 checkInt(value) {
-  if (value is !int) throw _argumentError(value);
+  if (value is !int) throw argumentErrorValue(value);
   return value;
 }
 
 checkBool(value) {
-  if (value is !bool) throw _argumentError(value);
+  if (value is !bool) throw argumentErrorValue(value);
   return value;
 }
 
 checkString(value) {
-  if (value is !String) throw _argumentError(value);
+  if (value is !String) throw argumentErrorValue(value);
   return value;
 }
 
 /**
  * Wrap the given Dart object and record a stack trace.
  *
  * The code in [unwrapException] deals with getting the original Dart
  * object out of the wrapper again.
  */
 @NoInline()
@@ skipping 2661 matching lines @@
   // This is a function that will return a helper function that does the
   // iteration of the sync*.
   //
   // Each invocation should give a body with fresh state.
   final dynamic /* js function */ _outerHelper;
 
   SyncStarIterable(this._outerHelper);
 
   Iterator get iterator => new SyncStarIterator(JS('', '#()', _outerHelper));
 }