Use ArgumentError.value in more places in js_lib.

sdk/lib/_internal/compiler/js_lib/js_string.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of _interceptors;
 
 /**
  * The interceptor class for [String]. The compiler recognizes this
  * class as an interceptor, and changes references to [:this:] to
  * actually use the receiver of the method, which is generated as an extra
@@ skipping 365 matching lines @@
     if (delta <= 0) return this;
     return this + padding * delta;
   }
 
   List<int> get codeUnits => new CodeUnits(this);
 
   Runes get runes => new Runes(this);
 
   int indexOf(Pattern pattern, [int start = 0]) {
     checkNull(pattern);
-    if (start is! int) throw new ArgumentError(start);
+    if (start is! int) throw argumentErrorValue(start);
     if (start < 0 || start > this.length) {
       throw new RangeError.range(start, 0, this.length);
     }
     if (pattern is String) {
       return stringIndexOfStringUnchecked(this, pattern, start);
     }
     if (pattern is JSSyntaxRegExp) {
       JSSyntaxRegExp re = pattern;
       Match match = firstMatchAfter(re, this, start);
       return (match == null) ? -1 : match.start;
     }
     for (int i = start; i <= this.length; i++) {
       if (pattern.matchAsPrefix(this, i) != null) return i;
     }
     return -1;
   }
 
   int lastIndexOf(Pattern pattern, [int start]) {
     checkNull(pattern);
     if (start == null) {
       start = length;
     } else if (start is! int) {
-      throw new ArgumentError(start);
+      throw argumentErrorValue(start);
     } else if (start < 0 || start > this.length) {
       throw new RangeError.range(start, 0, this.length);
     }
     if (pattern is String) {
       String other = pattern;
       if (start + other.length > this.length) {
         start = this.length - other.length;
       }
       return stringLastIndexOfUnchecked(this, other, start);
     }
     for (int i = start; i >= 0; i--) {
       if (pattern.matchAsPrefix(this, i) != null) return i;
     }
     return -1;
   }
 
   bool contains(Pattern other, [int startIndex = 0]) {
     checkNull(other);
     if (startIndex < 0 || startIndex > this.length) {
       throw new RangeError.range(startIndex, 0, this.length);
     }
     return stringContainsUnchecked(this, other, startIndex);
   }
 
   bool get isEmpty => length == 0;
 
   bool get isNotEmpty => !isEmpty;
 
   int compareTo(String other) {
-    if (other is !String) throw new ArgumentError(other);
+    if (other is !String) throw argumentErrorValue(other);
     return this == other ? 0
         : JS('bool', r'# < #', this, other) ? -1 : 1;
   }
 
   // Note: if you change this, also change the function [S].
   String toString() => this;
 
   /**
    * This is the [Jenkins hash function][1] but using masking to keep
    * values in SMI range.
@@ skipping 17 matching lines @@
   Type get runtimeType => String;
 
   int get length => JS('int', r'#.length', this);
 
   String operator [](int index) {
     if (index is !int) throw diagnoseIndexError(this, index);
     if (index >= length || index < 0) throw diagnoseIndexError(this, index);
     return JS('String', '#[#]', this, index);
   }
 }