Issue 11783027: Small improvement on the "delete temp dir on windows"-hack in the annotated steps script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11783027: Small improvement on the "delete temp dir on windows"-hack in the annotated steps script (Closed)

Created:
7 years, 11 months ago by kustermann

Modified:
7 years, 11 months ago

Reviewers:
ricow1, Emily Fortuna

CC:
reviews_dartlang.org, Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Small improvement on the "delete temp dir on windows"-hack in the annotated steps script Committed: https://code.google.com/p/dart/source/detail?r=16787

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	tools/bots/compiler.py	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/11783027/diff/2001/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/11783027/diff/2001/tools/bots/compiler.py#newcode261 tools/bots/compiler.py:261: for name in os.listdir(temp_dir): Should we do: for ...

7 years, 11 months ago (2013-01-08 10:39:37 UTC) #2

kustermann

https://codereview.chromium.org/11783027/diff/2001/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/11783027/diff/2001/tools/bots/compiler.py#newcode261 tools/bots/compiler.py:261: for name in os.listdir(temp_dir): On 2013/01/08 10:39:37, ricow1 wrote: ...

7 years, 11 months ago (2013-01-08 11:24:49 UTC) #3

Message was sent while issue was closed.

lgtm. Thanks, Martin!

Expand Messages | Collapse Messages

Issue 11783027: Small improvement on the "delete temp dir on windows"-hack in the annotated steps script (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages