Small improvement on the "delete temp dir on windows"-hack in the annotated steps script

tools/bots/compiler.py

 #!/usr/bin/python
 
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """
 Dart2js buildbot steps
 
 Runs tests for the  dart2js compiler.
@@ skipping 239 matching lines @@
   This problem also occurs with batch tests in Firefox. For some reason selenium
   automatically deletes the temporary profiles for Firefox for one browser,
   but not multiple ones when we have many open batch tasks running. This
   behavior has not been reproduced outside of the buildbots.
 
   Args:
      - system: either 'linux', 'mac', 'win7', or 'win8'
      - browser: one of the browsers, see GetBuildInfo
   """
   if system.startswith('win'):
-    shutil.rmtree('C:\\Users\\chrome-bot\\AppData\\Local\\Temp',
-        ignore_errors=True)
+    temp_dir = 'C:\\Users\\chrome-bot\\AppData\\Local\\Temp'
+    for name in os.listdir(temp_dir):

[ricow1, 2013/01/08 10:39:37]

Should we do:
for root, dirs, files in os.walk(temp_dir):
  for f in files:
    os.unlink(join(root, f))
  for d in dirs:
    shutil.rmtree(join(root, d))

[kustermann, 2013/01/08 11:24:49]

Let's delete only directories, this hack only exists because of the profile
directories.

+      shutil.rmtree(temp_dir + "\\" + name, ignore_errors=True)
   elif browser == 'ff' or 'opera':
     # Note: the buildbots run as root, so we can do this without requiring a
     # password. The command won't actually work on regular machines without
     # root permissions.
     _DeleteTempWebdriverProfiles('/tmp')
     _DeleteTempWebdriverProfiles('/var/tmp')
 
 
 def GetHasHardCodedCheckedMode(build_info):
   # TODO(ricow): We currently run checked mode tests on chrome on linux and
@@ skipping 41 matching lines @@
   """
   with bot.BuildStep('Build SDK and d8'):
     args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
             'dart2js_bot']
     print 'Build SDK and d8: %s' % (' '.join(args))
     bot.RunProcess(args)
 
 
 if __name__ == '__main__':
   bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler)