Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: tools/bots/compiler.py

Issue 11783027: Small improvement on the "delete temp dir on windows"-hack in the annotated steps script (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 3 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
4 # for details. All rights reserved. Use of this source code is governed by a 4 # for details. All rights reserved. Use of this source code is governed by a
5 # BSD-style license that can be found in the LICENSE file. 5 # BSD-style license that can be found in the LICENSE file.
6 6
7 """ 7 """
8 Dart2js buildbot steps 8 Dart2js buildbot steps
9 9
10 Runs tests for the dart2js compiler. 10 Runs tests for the dart2js compiler.
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 This problem also occurs with batch tests in Firefox. For some reason selenium 250 This problem also occurs with batch tests in Firefox. For some reason selenium
251 automatically deletes the temporary profiles for Firefox for one browser, 251 automatically deletes the temporary profiles for Firefox for one browser,
252 but not multiple ones when we have many open batch tasks running. This 252 but not multiple ones when we have many open batch tasks running. This
253 behavior has not been reproduced outside of the buildbots. 253 behavior has not been reproduced outside of the buildbots.
254 254
255 Args: 255 Args:
256 - system: either 'linux', 'mac', 'win7', or 'win8' 256 - system: either 'linux', 'mac', 'win7', or 'win8'
257 - browser: one of the browsers, see GetBuildInfo 257 - browser: one of the browsers, see GetBuildInfo
258 """ 258 """
259 if system.startswith('win'): 259 if system.startswith('win'):
260 shutil.rmtree('C:\\Users\\chrome-bot\\AppData\\Local\\Temp', 260 temp_dir = 'C:\\Users\\chrome-bot\\AppData\\Local\\Temp'
261 ignore_errors=True) 261 for name in os.listdir(temp_dir):
262 fullname = os.path.join(temp_dir, name)
263 if os.path.isdir(fullname):
264 shutil.rmtree(fullname, ignore_errors=True)
262 elif browser == 'ff' or 'opera': 265 elif browser == 'ff' or 'opera':
263 # Note: the buildbots run as root, so we can do this without requiring a 266 # Note: the buildbots run as root, so we can do this without requiring a
264 # password. The command won't actually work on regular machines without 267 # password. The command won't actually work on regular machines without
265 # root permissions. 268 # root permissions.
266 _DeleteTempWebdriverProfiles('/tmp') 269 _DeleteTempWebdriverProfiles('/tmp')
267 _DeleteTempWebdriverProfiles('/var/tmp') 270 _DeleteTempWebdriverProfiles('/var/tmp')
268 271
269 272
270 def GetHasHardCodedCheckedMode(build_info): 273 def GetHasHardCodedCheckedMode(build_info):
271 # TODO(ricow): We currently run checked mode tests on chrome on linux and 274 # TODO(ricow): We currently run checked mode tests on chrome on linux and
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 """ 316 """
314 with bot.BuildStep('Build SDK and d8'): 317 with bot.BuildStep('Build SDK and d8'):
315 args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode, 318 args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
316 'dart2js_bot'] 319 'dart2js_bot']
317 print 'Build SDK and d8: %s' % (' '.join(args)) 320 print 'Build SDK and d8: %s' % (' '.join(args))
318 bot.RunProcess(args) 321 bot.RunProcess(args)
319 322
320 323
321 if __name__ == '__main__': 324 if __name__ == '__main__':
322 bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler) 325 bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698