Issue 1176703002: Make guard_cid and nullable_cid half words.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1176703002: Make guard_cid and nullable_cid half words. (Closed)

Created:
5 years, 6 months ago by rmacnak

Modified:
5 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make guard_cid and nullable_cid half words. Add missing half-word instructions for ia32/x64. 46.0kB -> 38.4kB (-16.5%) of Field in hello world R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/f2b59c3ed91779f1675cbaf73424cb446990accf

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -101 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View		2 chunks	+28 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1	2 chunks	+28 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View	1	4 chunks	+32 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		6 chunks	+18 lines, -18 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		6 chunks	+26 lines, -22 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	6 chunks	+18 lines, -18 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		5 chunks	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		6 chunks	+18 lines, -18 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

5 years, 6 months ago (2015-06-10 21:14:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f2b59c3ed91779f1675cbaf73424cb446990accf (presubmit successful).