Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 1176703002: Make guard_cid and nullable_cid half words. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 06300e6b45ae1f0311905fb496532607b0c7abd8..b5f8482caa8cc58f1b3a0e5f17c479e5dde2397a 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -1460,17 +1460,17 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
if (value_cid == kDynamicCid) {
LoadValueCid(compiler, value_cid_reg, value_reg);
- __ cmpl(value_cid_reg, field_cid_operand);
+ __ cmpw(value_cid_reg, field_cid_operand);
__ j(EQUAL, &ok);
- __ cmpl(value_cid_reg, field_nullability_operand);
+ __ cmpw(value_cid_reg, field_nullability_operand);
} else if (value_cid == kNullCid) {
// Value in graph known to be null.
// Compare with null.
- __ cmpl(field_nullability_operand, Immediate(value_cid));
+ __ cmpw(field_nullability_operand, Immediate(value_cid));
} else {
// Value in graph known to be non-null.
// Compare class id with guard field class id.
- __ cmpl(field_cid_operand, Immediate(value_cid));
+ __ cmpw(field_cid_operand, Immediate(value_cid));
}
__ j(EQUAL, &ok);
@@ -1483,19 +1483,19 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
if (!field().needs_length_check()) {
// Uninitialized field can be handled inline. Check if the
// field is still unitialized.
- __ cmpl(field_cid_operand, Immediate(kIllegalCid));
+ __ cmpw(field_cid_operand, Immediate(kIllegalCid));
// Jump to failure path when guard field has been initialized and
// the field and value class ids do not not match.
__ j(NOT_EQUAL, fail);
if (value_cid == kDynamicCid) {
// Do not know value's class id.
- __ movl(field_cid_operand, value_cid_reg);
- __ movl(field_nullability_operand, value_cid_reg);
+ __ movw(field_cid_operand, value_cid_reg);
+ __ movw(field_nullability_operand, value_cid_reg);
} else {
ASSERT(field_reg != kNoRegister);
- __ movl(field_cid_operand, Immediate(value_cid));
- __ movl(field_nullability_operand, Immediate(value_cid));
+ __ movw(field_cid_operand, Immediate(value_cid));
+ __ movw(field_nullability_operand, Immediate(value_cid));
}
if (deopt == NULL) {
@@ -1508,7 +1508,7 @@ void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
ASSERT(!compiler->is_optimizing());
__ Bind(fail);
- __ cmpl(FieldAddress(field_reg, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(field_reg, Field::guarded_cid_offset()),
Immediate(kDynamicCid));
__ j(EQUAL, &ok);
@@ -1839,7 +1839,7 @@ void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ LoadObject(temp, Field::ZoneHandle(field().raw()));
- __ cmpl(FieldAddress(temp, Field::is_nullable_offset()),
+ __ cmpw(FieldAddress(temp, Field::is_nullable_offset()),
Immediate(kNullCid));
__ j(EQUAL, &store_pointer);
@@ -1847,15 +1847,15 @@ void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ testl(temp2, Immediate(1 << Field::kUnboxingCandidateBit));
__ j(ZERO, &store_pointer);
- __ cmpl(FieldAddress(temp, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(temp, Field::guarded_cid_offset()),
Immediate(kDoubleCid));
__ j(EQUAL, &store_double);
- __ cmpl(FieldAddress(temp, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(temp, Field::guarded_cid_offset()),
Immediate(kFloat32x4Cid));
__ j(EQUAL, &store_float32x4);
- __ cmpl(FieldAddress(temp, Field::guarded_cid_offset()),
+ __ cmpw(FieldAddress(temp, Field::guarded_cid_offset()),
Immediate(kFloat64x2Cid));
__ j(EQUAL, &store_float64x2);
@@ -2210,16 +2210,16 @@ void LoadFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
FieldAddress field_cid_operand(result, Field::guarded_cid_offset());
FieldAddress field_nullability_operand(result, Field::is_nullable_offset());
- __ cmpl(field_nullability_operand, Immediate(kNullCid));
+ __ cmpw(field_nullability_operand, Immediate(kNullCid));
__ j(EQUAL, &load_pointer);
- __ cmpl(field_cid_operand, Immediate(kDoubleCid));
+ __ cmpw(field_cid_operand, Immediate(kDoubleCid));
__ j(EQUAL, &load_double);
- __ cmpl(field_cid_operand, Immediate(kFloat32x4Cid));
+ __ cmpw(field_cid_operand, Immediate(kFloat32x4Cid));
__ j(EQUAL, &load_float32x4);
- __ cmpl(field_cid_operand, Immediate(kFloat64x2Cid));
+ __ cmpw(field_cid_operand, Immediate(kFloat64x2Cid));
__ j(EQUAL, &load_float64x2);
// Fall through.
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698