Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1175803003: Inline instanceOf and 'as' operations; fix a bug in code emission (Closed)

Created:
5 years, 6 months ago by srdjan
Modified:
5 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Inline instanceOf and 'as' operations; fix a bug in code emission BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/acadc9017c6fecf6b625f393458a6d273d0e2e90

Patch Set 1 #

Patch Set 2 : m #

Total comments: 2

Patch Set 3 : c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -15 lines) Patch
M runtime/vm/flow_graph_compiler_arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 6 months ago (2015-06-10 16:55:40 UTC) #2
regis
LGTM, except the commented out line. https://codereview.chromium.org/1175803003/diff/20001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/1175803003/diff/20001/runtime/vm/flow_graph_optimizer.cc#newcode4235 runtime/vm/flow_graph_optimizer.cc:4235: // ReplaceWithTypeCast(instr); Why ...
5 years, 6 months ago (2015-06-10 19:36:23 UTC) #3
srdjan
https://codereview.chromium.org/1175803003/diff/20001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/1175803003/diff/20001/runtime/vm/flow_graph_optimizer.cc#newcode4235 runtime/vm/flow_graph_optimizer.cc:4235: // ReplaceWithTypeCast(instr); On 2015/06/10 19:36:23, regis wrote: > Why ...
5 years, 6 months ago (2015-06-10 19:45:23 UTC) #4
srdjan
5 years, 6 months ago (2015-06-10 20:18:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
acadc9017c6fecf6b625f393458a6d273d0e2e90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698